Closed
Bug 1359267
Opened 8 years ago
Closed 8 years ago
Signing Tour Notification XPI
Categories
(Add-on SDK Graveyard :: General, enhancement)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nyee, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
application/x-xpinstall
|
Details |
Tour Notification Funnelcake is shipping on April 27th with a Tour Notification add-on. Requesting XPI sign off from the AMO team.
Reporter | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Jorge: I got this error when trying to upload the XPI to AMO for listing:
https://bugzilla.mozilla.org/show_bug.cgi?id=1348127#c127
What should we do?
Flags: needinfo?(jorge)
Reporter | ||
Comment 3•8 years ago
|
||
i think this is what needs to happen if this didnt happen already
From Schalks email:
“Here is my proposal for a possible solution. We repackage(there will be some development needed) the add-on as a “transitional” add-on with an empty web-extension in it’s belly. This will mean that the file it is looking for will be present and it will pass AMO and be installable post Fx 53.”
Jorge let me know if there is a better way to proceed.
Comment 4•8 years ago
|
||
That will not pass on AMO, it's still not a WebExtension.
Comment 5•8 years ago
|
||
Schalk: Is your latest add-on a webextension or SDK? It needs to be a WebExtension with an XPI inside.
Flags: needinfo?(jorge) → needinfo?(schalk.neethling.bugs)
Comment 6•8 years ago
|
||
(In reply to Chris More [:cmore] from comment #5)
> Schalk: Is your latest add-on a webextension or SDK? It needs to be a
> WebExtension with an XPI inside.
Wait, that's not a thing. It has to be a WebExtension if its a new add-on or work with Jorge to work around the block on AMO.
Reporter | ||
Comment 7•8 years ago
|
||
Given our tight schedule, I scheduled a meeting to talk through this further at 12:30pm today.
Flags: needinfo?(jorge)
Flags: needinfo?(chrismore.bugzilla)
Flags: needinfo?(amckay)
Comment 8•8 years ago
|
||
Wasn't that XPI already signed? The ID should be on AMO and it should be possible to upload a new version for listing. Did you change the ID? Are you trying to list a file that was already signed?
Flags: needinfo?(jorge)
Reporter | ||
Comment 9•8 years ago
|
||
the XPI was self signed. schalk took care of that process for us. Schalk can you provide more information for us?
Comment 10•8 years ago
|
||
It looks like someone deleted the self-signed add-on on AMO, which isn't necessary, and also the reason why you're running into this issue. I'll try uploading it myself.
Comment 11•8 years ago
|
||
Okay, I uploaded it under a different ID (@onboard-v2 ). I need someone to review the name, slug, descriptions, etc. on this page: https://addons.mozilla.org/developers/addon/firefox-onboard/edit
Once it looks good, I can ask someone in the review team to give it a look and approve it so it's signed and published.
Reporter | ||
Comment 12•8 years ago
|
||
cmore can you take on this(In reply to Jorge Villalobos [:jorgev] from comment #11)
> Okay, I uploaded it under a different ID (@onboard-v2 ). I need someone to
> review the name, slug, descriptions, etc. on this page:
> https://addons.mozilla.org/developers/addon/firefox-onboard/edit
cmore can you take on this action item?
> Once it looks good, I can ask someone in the review team to give it a look
> and approve it so it's signed and published.
Flags: needinfo?(schalk.neethling.bugs)
Flags: needinfo?(chrismore.bugzilla)
Flags: needinfo?(amckay)
Comment 13•8 years ago
|
||
:jorgev:
Slug: can you make it "firefox-onboarding-tour" to make it more unique to this experiment?
Icon: use lightbulb icon as I did in previous ones: https://addons.mozilla.org/en-US/developers/addon/firefox-all-aboard-1-6/edit like https://addons.cdn.mozilla.net/user-media/addon_icons/789/789998-64.png?modified=1488367221&1493144919168
Description: Looks fine
Comment 14•8 years ago
|
||
The add-on is public now https://addons.mozilla.org/addon/firefox-onboarding-tour/
Reporter | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•