Closed
Bug 1359309
Opened 8 years ago
Closed 8 years ago
Give mozilla::TaskQueue a name
Categories
(Core :: XPCOM, enhancement, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
It will help debug the crash in bug 1347056 by dumping the name of the AbstractThread when dispatch fails.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Updated•8 years ago
|
Summary: Give AbstractThread a name → Give mozilla::TaskQueue a name
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8861781 -
Flags: review?(jyavenard)
Attachment #8861782 -
Flags: review?(jyavenard)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8861781 [details]
Bug 1359309. P1 - give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures.
https://reviewboard.mozilla.org/r/133784/#review136784
::: xpcom/threads/TaskQueue.cpp:80
(Diff revision 1)
> MOZ_COUNT_CTOR(TaskQueue);
> }
>
> +TaskQueue::TaskQueue(already_AddRefed<nsIEventTarget> aTarget,
> + bool aSupportsTailDispatch)
> + : TaskQueue(Move(aTarget), "UnknownTaskQueue", aSupportsTailDispatch)
Unnamed instead maybe? since it's not unknown per say
Attachment #8861781 -
Flags: review?(jyavenard) → review+
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8861782 [details]
Bug 1359309. P2 - dump the name of the TaskQueue when Dispatch() fails.
https://reviewboard.mozilla.org/r/133786/#review137218
Attachment #8861782 -
Flags: review?(jyavenard) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 7•8 years ago
|
||
Thanks!
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
P1 - give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures. r=jya
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029
P2 - dump the name of the TaskQueue when Dispatch() fails. r=jya
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•