Closed Bug 1359541 Opened 8 years ago Closed 8 years ago

Enable eslint on mobile/android/tests

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1357557 +++
I'm pretty sure I haven't broken any tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d5536a9fd5a79bbc2b30d22f1033cae7918c84c :standard8 -- This is new ground for me; I'd appreciate lots of feedback. :snorp -- Any concerns with linting mobile/android/tests?
Attachment #8861563 - Flags: review?(standard8)
Attachment #8861563 - Flags: review?(snorp)
Comment on attachment 8861563 [details] [diff] [review] enable eslint on mobile/android/tests Review of attachment 8861563 [details] [diff] [review]: ----------------------------------------------------------------- Looking good. Please can you also remove the mobile/android/tests/.eslintrc file, as that isn't necessary (the various *-test configs define those for us). ::: mobile/android/tests/.eslintrc.js @@ +1,5 @@ > +"use strict"; > + > +module.exports = { > + "extends": [ > + "plugin:mozilla/mochitest-test" There's no simple mochitests in the test directory as far as I can tell, so you shouldn't need this file.
Attachment #8861563 - Flags: review?(standard8) → review+
Attachment #8861563 - Flags: review?(snorp) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4d43ed9b7f Enable eslint on mobile/android/tests; r=standard8,snorp
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: