Closed
Bug 1359545
Opened 8 years ago
Closed 8 years ago
Update tests to pass triggeringPrincipal to loadURI
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ckerschb
Blocks: require-triggering-principal
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Assignee | ||
Comment 1•8 years ago
|
||
There is a bunch more work waiting for us/me. Let's get the low hanging fruit out of the way before we can flip the assertion within Bug 1333030.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b176e29b4b8bc04efb9fe89f733328d173f373e
Attachment #8861590 -
Flags: review?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch
The browser/ tests should get review from someone familiar with them. In particular, for browser_async_remove_tab.js it's not clear to me at all that the changes are right: the import() is in the chrome process but afaict the string is eval'ed in the content process.
r=me on the DOM and toolkit tests.
Attachment #8861590 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch
Gijs, can you take a look at the browser/ test changes?
Attachment #8861590 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•8 years ago
|
||
Comment on attachment 8861590 [details] [diff] [review]
bug_1359545_update_tests_to_pass_triggering_to_loaduri.patch
Review of attachment 8861590 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/sessionstore/test/browser_async_remove_tab.js
@@ +1,3 @@
> "use strict";
>
> +Cu.import("resource://gre/modules/Services.jsm");
You shouldn't need to do this. Here or in any other browser_ tests.
Attachment #8861590 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8861590 -
Attachment is obsolete: true
Attachment #8862123 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9210201f671
Update tests to pass triggeringPrincipal to loadURI. r=bz, r=gijs
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•