Open the toolbar customization window and move a button somewhere and choose 'Exit Customization'. The code in browser-customization.js _customizationEnding has the line: if (aDetails.changed) { ... } aDetails is an object, but aDetails.changed is undefined, so some state updating doesn't happen. This is affecting the test in bug 1356587.

Oof yes, we should just get rid of this stuff: http://searchfox.org/mozilla-central/rev/3dc6ceb42746ab40f1441e1e659ffb8f62ae78e3/browser/base/content/browser-customization.js#60-77

The reason I filed this bug (found with bug 1356587) is that we want updateEditUIVisibility() to be called when you exit customization mode because the edit button visibility may have changed now that you moved the buttons somewhere else.

(In reply to Neil Deakin from comment #3) > The reason I filed this bug (found with bug 1356587) is that we want > updateEditUIVisibility() to be called when you exit customization mode > because the edit button visibility may have changed now that you moved the > buttons somewhere else. I see - would you rather take over this bug?

I'm not really familiar with this code. Is there something else that replaces what it should be doing?