Closed Bug 1359794 Opened 8 years ago Closed 7 years ago

The Grid Cell highlighting should take transformation into account

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: zer0, Assigned: zer0)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

If an element with `display: grid` is highlighted by Grid Inspector and has CSS transformations applied, when hovering in the layout panel's grid outline the cell does not take the transformation into account.
Assignee: nobody → zer0
Priority: -- → P3
Status: NEW → ASSIGNED
No longer blocks: 1347964
Comment on attachment 8874469 [details] Bug 1359794 - grid cell highlighting now are properly transformed, infobars are better positioned; https://reviewboard.mozilla.org/r/145842/#review149830 ::: devtools/server/actors/highlighters/css-grid.js:116 (Diff revision 1) > + * @param {Array} [matrix=identity()] > + * A transformation matrix to apply. > + * @return {Array} > + * The rect four corners' points transformed by the matrix given. > + */ > +function diagonalToPoints(x1, y1, x2, y2, matrix = identity()) { s/diagonalToPoints/getPointsfromDiagonal ::: devtools/server/actors/highlighters/css-grid.js:138 (Diff revision 1) > + * @param {Array} points > + * The four points. > + * @return {Object} > + * A DOMRect-like object. > + */ > +function pointsToBounds(points) { s/pointsToBoundss/getBoundsFromPoints ::: devtools/server/actors/highlighters/css-grid.js:162 (Diff revision 1) > + * @param {Array} points > + * The four points. > + * @return {String} > + * A Path Description that can be used in svg's <path> element. > + */ > +function pointsToPathDescription(points) { s/pointsToPathDescription/getPathDescriptionFromPoints
Attachment #8874469 - Flags: review?(gl) → review+
Pushed by mferretti@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc53ed710486 grid cell highlighting now are properly transformed, infobars are better positioned; r=gl
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: