Magnus Melin [:mkmelin] Assignee
	Description • 7 years ago

+++ This bug was initially created as a clone of Bug #682474 +++

I keep seeing a "self not defined" error.
I'm didn't investigate exactly what problem it causes, but the fix is pretty clear.

Apparently this code was added in bug 682474

	Philipp Kewisch [:Fallen] [:📆][:🧩]
	Comment 1 • 7 years ago

Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch

Review of attachment 8862120 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! I don't know how I missed that.

	Philipp Kewisch [:Fallen] [:📆][:🧩]
	Comment 2 • 7 years ago

https://hg.mozilla.org/comm-central/rev/f41d24c7cdde0697e9c3e029705e80493ea4be50
https://hg.mozilla.org/releases/comm-beta/rev/71dde03413c7e8d31bcbba342ab87f8251a73bbb

I didn't push to aurora because we've basically removed it, let me know if this is wrong.

	Jorg K (CEST = GMT+2)
	Comment 3 • 7 years ago

Yes, and please remove the Aurora approval.

BTW, it would have been better to let me handle the landings since I have some lined up in the next few hours.

	Philipp Kewisch [:Fallen] [:📆][:🧩]
	Comment 4 • 7 years ago

Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch

I understand, but Wayne was looking to build beta so I took care of this one. Thanks for helping out!

	Jorg K (CEST = GMT+2)
	Comment 6 • 7 years ago

This depends on bug 682474 which hasn't been uplifted to ESR yet.

	Philipp Kewisch [:Fallen] [:📆][:🧩]
	Comment 7 • 7 years ago

That should be fine, this doesn't need uplift to ESR until bug 682474 is uplifted.

	Philipp Kewisch [:Fallen] [:📆][:🧩]
	Comment 8 • 7 years ago

Comment on attachment 8862120 [details] [diff] [review]
bugXXX_self_not_defined.patch

a+ since you requested approval for the dependent patch

	Jorg K (CEST = GMT+2)
	Comment 9 • 7 years ago

TB 52 ESR, Calendar 5.4.x:
https://hg.mozilla.org/releases/comm-esr52/rev/2e1b58d59899

	Jorg K (CEST = GMT+2)
	Comment 10 • 7 years ago

TB 52 ESR - Backout:
https://hg.mozilla.org/releases/comm-esr52/rev/762c13339d3d90f0b944e00850da059a58780801

	Magnus Melin [:mkmelin] Assignee
	Comment 11 • 7 years ago

I doubt this caused the gmail problems. What the backout means is basically caldav oauth won't connect so you probably broke calendar authentication. (At least for some cases, didn't look exactly how this is used.)

I suggest to add this back on esr.

	Jorg K (CEST = GMT+2)
	Comment 12 • 7 years ago

This got backed out at part of backing out bug 682474. Quoting Phillip's e-mail on tb-drivers:

Jörg:
> do I back out bug 1176399 alone or also bug 682474 and
> bug 1359967.

Philipp:
They are connected, so you'd have to back them all out.

	Magnus Melin [:mkmelin] Assignee
	Comment 13 • 7 years ago

Ah, I see. But 682474 caused this but that got backed out.

	Jorg K (CEST = GMT+2)
	Comment 14 • 7 years ago

Beta (TB 55, Calendar 5.7) backout:
https://hg.mozilla.org/releases/comm-beta/rev/e927b799e817d3b3066f166077541ca986fa902e

	Jorg K (CEST = GMT+2)
	Comment 15 • 7 years ago

Backout from trunk:
https://hg.mozilla.org/comm-central/rev/74c3098a32249610e77573a56c920f9f92a55830

Sorry, I had to back this out since the next merge date is coming and I can't continue to back it out from all the betas we ship.

	Magnus Melin [:mkmelin] Assignee
	Comment 16 • 5 years ago

This got relanded together with other stuff at some point.