Closed
Bug 1359989
Opened 8 years ago
Closed 5 years ago
uninterruptible reflow at _openPanel@resource:///modules/UrlbarView.jsm
Categories
(Firefox :: General, defect, P4)
Firefox
General
Tracking
()
People
(Reporter: marco, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [ohnoreflow][reserve-photon-performance])
Here's the stack:
openPopupAtScreen@chrome://global/content/bindings/popup.xml:70:15
openContextMenu@chrome://browser/content/nsContextMenu.js:58:3
receiveMessage@chrome://browser/content/tabbrowser.xml:5010:15
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
Updated•8 years ago
|
Component: Untriaged → General
Updated•8 years ago
|
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p1][photon-performance]
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
Updated•8 years ago
|
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
Comment 2•7 years ago
|
||
I think this one is actually caused by platform code. Around http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/layout/xul/nsXULPopupManager.cpp#778 all the nsXULPopupManager::ShowPopup* methods call GetPopupFrameForContent with true as the aShouldFlush parameter.
We also hit this with a different stack when opening the awesomebar panel:
"openPopup@chrome://global/content/bindings/popup.xml:66:15",
"_openAutocompletePopup@chrome://browser/content/urlbarBindings.xml:1889:11",
"openAutocompletePopup@chrome://browser/content/urlbarBindings.xml:1803:11",
"openPopup@chrome://global/content/bindings/autocomplete.xml:393:13",
"set_popupOpen@chrome://global/content/bindings/autocomplete.xml:103:10",
"notifyResults@file:///<appdir>/components/UnifiedComplete.js:2193:5",
Updated•7 years ago
|
Blocks: photon-perf-awesomebar
Updated•7 years ago
|
Priority: P3 → P4
Comment 3•7 years ago
|
||
I cannot reproduce this one anymore.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Comment 4•6 years ago
|
||
(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)
I cannot reproduce this one anymore.
browser/base/content/test/performance/browser_urlbar_search.js has two stacks referring to this bug.
Status: RESOLVED → REOPENED
Flags: needinfo?(mconley)
Resolution: WORKSFORME → ---
Comment 5•6 years ago
|
||
So it does! Back into the queue it goes.
Flags: needinfo?(mconley)
Summary: 1.00ms uninterruptible reflow at openPopupAtScreen@chrome://global/content/bindings/popup.xml:70:15 → uninterruptible reflow at _openAutocompletePopup@chrome://browser/content/urlbarBindings.xml
Updated•5 years ago
|
Depends on: 1551598
Summary: uninterruptible reflow at _openAutocompletePopup@chrome://browser/content/urlbarBindings.xml → uninterruptible reflow at _openPanel@resource:///modules/UrlbarView.jsm
Comment 6•5 years ago
|
||
Should be fixed by 1551598
Status: REOPENED → RESOLVED
Closed: 7 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Updated•3 years ago
|
Performance Impact: --- → P2
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][reserve-photon-performance]
You need to log in
before you can comment on or make changes to this bug.
Description
•