Closed Bug 1360220 Opened 8 years ago Closed 8 years ago

Replace BytecodeEmitter::emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

bug1360220.patch
(deleted), patch
shu
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch bug1360220.patch (deleted) — — Splinter Review
We now have a dedicated byte code for RequireObjectCoercible, so we no longer need to call the self-hosted method.
Attachment #8862502 - Flags: review?(shu)
Comment on attachment 8862502 [details] [diff] [review] bug1360220.patch Review of attachment 8862502 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch.
Attachment #8862502 - Flags: review?(shu) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed8623eefe6c Replace emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE. r=shu
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed8623eefe6c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Pushed by gkwong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/430f5feeec95 Backed out changeset ed8623eefe6c for causing fuzzblocker bug 1362590, rs=shu on IRC
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Bug 1362590, comment #6.
Flags: needinfo?(andrebargull)
Let's try to get this into the tree again, now that bug 1362590 is fixed. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a2f0b28bd97100195302a9d392fa7875e6900d8
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/714b7caf7e00 Replace emitRequireObjectCoercible with JSOP_CHECKOBJCOERCIBLE. r=shu
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/714b7caf7e00
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: