Closed Bug 1360477 Opened 7 years ago Closed 7 years ago

Enlarge favicons size limit and rescale bigger icons instead of discarding them.

Categories

(Toolkit :: Places, defect, P1)

Product:
Toolkit
Component:
Places
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: nightly-community, regression, reproducible, Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1360477 - Enlarge favicons size limit and rescale bigger icons instead of discarding them.
(deleted), text/x-review-board-request
adw
: review+
Details 
The initial limit was too small for the kind of icons we want to support, and any icon over that limit was discarded.
We can instead rescale down an icon until it fits our limit.
Blocks: 1356525
No longer blocks: 1359456
Comment on attachment 8862755 [details]
Bug 1360477 - Enlarge favicons size limit and rescale bigger icons instead of discarding them.

https://reviewboard.mozilla.org/r/134622/#review137854
Attachment #8862755 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/825b897ed59a
Enlarge favicons size limit and rescale bigger icons instead of discarding them. r=adw
https://hg.mozilla.org/mozilla-central/rev/825b897ed59a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Thank you very much Marco Bonardo [::mak]! \o/

I'm marking this bug as VERIFIED, as it's not reproducible anymore with STR from bug #1359456 comment #1, starting from Mozilla Firefox Nightly 55.0a1 (2017-04-30).
Status: RESOLVED → VERIFIED
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: fixed → verified
status-firefox-esr45: --- → unaffected
status-firefox-esr52: --- → affected
Keywords: nightly-community, regression, reproducible
Version: unspecified → 55 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: