Closed
Bug 1360532
Opened 8 years ago
Closed 7 years ago
Hover state should apply to all textbox fields
Categories
(Firefox :: Settings UI, defect, P2)
Firefox
Settings UI
Tracking
()
RESOLVED
DUPLICATE
of bug 1377021
Firefox 57
People
(Reporter: hyacoub, Unassigned)
References
()
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
Details |
[Affected versions]:
Nightly 55.0a1
[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12
[Steps to reproduce]:
1. Launch firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences" and hover on the "Search" field.
[Expected result]:
Hover state should be applied on the "Search" field and the border should become darker according to the documentation.
[Actual result]:
Hover state isn't applied on the "Search" field.
Updated•8 years ago
|
Updated•8 years ago
|
Flags: qe-verify+
Updated•8 years ago
|
QA Contact: hani.yacoub
Comment 1•8 years ago
|
||
According spec https://mozilla.invisionapp.com/share/ZDAGPK3AF#/screens/218928188, we're going to introduce a new hover state color (dark gray). At the time I found that the checkbox-check color has defined in common.css which is used widely by entire Firefox browser. Can we accept to have a preference specific style override in preferences.inc.css?
Flags: needinfo?(mconley)
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
Pushed patch for asking first round review.
Note that I only apply the new hover state highlight for search input (a.k.a textbox[type="search"]) but not for other textbook in preferences panel. I think it would be safe if we apply all textbox in pref panel (it should be in the scope in visual refresh but it's good to go in this bug IMO).
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8864061 [details]
Bug 1360532 - Hover state is not applied on the "Search" field
https://reviewboard.mozilla.org/r/135778/#review138902
::: browser/themes/shared/incontentprefs/preferences.inc.css:57
(Diff revision 1)
> +.main-content textbox[type="search"]:hover {
> + border-color: #6a6868;
> +}
This should probably be consistent throughout all textboxes, so I would probably add it here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#475
::: browser/themes/shared/incontentprefs/preferences.inc.css:61
(Diff revision 1)
> +.main-content textbox[type="search"][focused="true"] {
> + border-color: var(--in-content-border-focus);
> +}
This is already covered by: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#481
Updated•8 years ago
|
Priority: -- → P1
Comment 5•8 years ago
|
||
Per offline discussion with Helen, this feature will be moved to visual refresh scope. The hover state should apply to all input fields in about:preferences page but not only apply to a single search input field.
I'm going to unassign myself and postpone this work until visual refresh spec is more clear for all hover state.
Updated•8 years ago
|
Target Milestone: --- → Firefox 57
Comment 6•8 years ago
|
||
Flags: needinfo?(mconley)
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8864061 [details]
Bug 1360532 - Hover state is not applied on the "Search" field
https://reviewboard.mozilla.org/r/135778/#review139332
Apparently, this is a more general change that we want in about:preferences, so clearing review request.
Attachment #8864061 -
Flags: review?(mconley)
Updated•7 years ago
|
Target Milestone: Firefox 56 → Firefox 57
Version: 55 Branch → unspecified
Updated•7 years ago
|
No longer blocks: 1357306
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: qe-verify+
QA Contact: hani.yacoub
Resolution: --- → DUPLICATE
Whiteboard: [photon-preference]
You need to log in
before you can comment on or make changes to this bug.
Description
•