This will make a subsequent diff easier to read. It also makes this code more intelligible, IMO. Review commit: https://reviewboard.mozilla.org/r/135326/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135326/

Previously, the "version" variable was the literal directory name. In most cases, this should match exactly to the version reported by `hg --version`. However, in the case of the "@" directory, the version would be "@" which is nonsense. We already have a helper function to resolve the Mercurial version given an hg executable. So we plug that in to populate HGVERSION with the actual version. Review commit: https://reviewboard.mozilla.org/r/135328/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135328/

We add one of these for every version we support so we can conditionalize test execution. Review commit: https://reviewboard.mozilla.org/r/135330/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135330/

The pushlog extension only needs to run on servers. I'm not sure why we claim support for older versions. Probably a cargo cult (on my part). This is causing a problem with tests because tests load the hgmo extension (which has dropped compatibility <4.1) and this results in a warning being printed on <4.1 Mercurials, causing tests to fail. So let's mark the extensions with the same compatibility as the hgmo extension so the tests don't run anywhere the hgmo extension isn't also compatible. Review commit: https://reviewboard.mozilla.org/r/135332/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135332/

As part of running tests against all Mercurial versions, this test was failing on old versions because it attempts to load the server.py extension, which requires 4.1. The code in run-tests that parses extension compatibility out of "testedwith" variables normally prevents this. However, since hgext/reviewboard/ has 2 extensions and client.py lists compatibility with <4.1, it was getting picked up. All other tests don't need this #require because server.py runs in Docker and Docker's Mercurial version is defined by the Docker environment. Review commit: https://reviewboard.mozilla.org/r/135334/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135334/

blackbox logging changed slightly in Mercurial 4.2. Adjust test output accordingly. We need to copy the hghave file into the test directory in order for the #if to work. This is a limitation of Mercurial's test harness (it requires an "hghave" executable next to the test file). Review commit: https://reviewboard.mozilla.org/r/135336/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135336/

All extensions are now marked as compatibile with Mercurial 4.2. As of this change, all non-Docker tests pass with both 4.1 and 4.2. In some cases, the compatibility might be premature since Docker images aren't yet running 4.2. I'm fine with that. We'll flush those out when we upgrade the Docker images to 4.2. Review commit: https://reviewboard.mozilla.org/r/135338/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/135338/