Closed
Bug 1361291
Opened 8 years ago
Closed 8 years ago
the UI doesn't know anymore when to use the inverted defaultFavicon
Categories
(Toolkit :: Places, enhancement, P2)
Toolkit
Places
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mak, Unassigned)
References
Details
(Whiteboard: [fxsearch])
The problem here is that we moved from "no-favicon or favicon" to "page-icon:favicon" in the UI.
The page-icon protocol doesn't know when the UI may want an inverted icon, since it's a backend protocol. For this I can only see some possible solutions so far:
1. add some kind of invert filter to the ui css
2. add a ref to the page-icon that tells it which default favicon it wants
3. make the backend components fetch whether there's an icon or not, and use page-icon only when there's an icon
3 obviously has code complication and I/O implications, since every time we'd have to join with icons tables to check whether there's an icon.
Reporter | ||
Updated•8 years ago
|
Blocks: PlacesHiresFavicons
Reporter | ||
Comment 1•8 years ago
|
||
and 1. is not feasible since the ui doesn't know when the protocol returns the default icon.
Reporter | ||
Comment 3•8 years ago
|
||
we don't need this anymore since the new svg favicon works fine on selections
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•