Closed
Bug 1361513
Opened 7 years ago
Closed 7 years ago
coverity report: Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.
Categories
(Core :: Layout: Block and Inline, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | wontfix |
firefox54 | --- | wontfix |
firefox55 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, regression, Whiteboard: [CID 1405755])
** CID 1405755: Uninitialized members (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()
________________________________________________________________________________________________________
*** CID 1405755: Uninitialized members (UNINIT_CTOR)
/layout/generic/nsInlineFrame.h: 146 in nsInlineFrame::nsInlineFrame(nsStyleContext *, mozilla::FrameType)()
140 mSetParentPointer = false;
141 }
142 };
143
144 nsInlineFrame(nsStyleContext* aContext, mozilla::FrameType aType)
145 : nsContainerFrame(aContext, aType)
>>> CID 1405755: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mBaseline" is not initialized in this constructor nor in any functions that it calls.
146 {}
147
148 explicit nsInlineFrame(nsStyleContext* aContext)
149 : nsInlineFrame(aContext, mozilla::FrameType::Inline)
150 {}
151
Reporter | ||
Updated•7 years ago
|
Keywords: regression
Reporter | ||
Comment 1•7 years ago
|
||
We should init mBaseline in the ctor to NS_INTRINSIC_WIDTH_UNKNOWN to catch any errors.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c74c35cc714 Initialize nsInlineFrame::mBaseline. r=mats
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c74c35cc714
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Assignee: nobody → emilio+bugs
status-firefox53:
--- → wontfix
status-firefox54:
--- → affected
status-firefox-esr52:
--- → unaffected
Updated•7 years ago
|
Blocks: coverity-analysis
Updated•7 years ago
|
Whiteboard: [CID 1405755]
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•