Brian Grinstead [:bgrins] Reporter
	Description • 8 years ago

STR:
Open console frontend in launchpad
On target tab, run `console.log("hi")`

I see this warning in the launchpad tab:

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `Message`. It was passed a child from MessageContainer. See https://fb.me/react-warning-keys for more information.
    in span (created by MessageContainer)
    in Message (created by MessageContainer)
    in MessageContainer (created by ConsoleOutput)
    in div (created by ConsoleOutput)
    in ConsoleOutput (created by Connect(ConsoleOutput))
    in Connect(ConsoleOutput)
    in div
    in Provider

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 1 • 8 years ago

This is due to the "Function" change. Since we don't use components for GripMessageBody, the key need to be put in Reps.
I created https://github.com/devtools-html/reps/issues/146 to do the Rep work, and Bug 1362037 to land a new bundle

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 3 • 7 years ago

Note that to see the error (and the fix with the patch in Comment 2), you need to run the app with `npm run dev` or `yarn run dev` to have React in dev mode, and thus the warning messages.

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8878471 [details]
Bug 1361541 - Fix warning messages in dev mode.

https://reviewboard.mozilla.org/r/149824/#review155116

Fixes the problem for me, thanks!

Honza

	Pulsebot
	Comment 5 • 7 years ago

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17948ebf67e5
Fix warning messages in dev mode. r=Honza

	Carsten Book [:Tomcat]
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/17948ebf67e5