Closed Bug 1361560 Opened 8 years ago Closed 8 years ago

Enable Form Autofill by default on Nightly

Categories

(Toolkit :: Form Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file, 1 obsolete file)

In order to get more testing of the feature, let's enable the feature for Nightly-only.
We either need bug 1340477 landed or we need to also enable dom.forms.autocomplete.experimental temporarily on Nightly-only.
Depends on: 1362584
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Version: 53 Branch → Trunk
Comment on attachment 8865060 [details] Bug 1361560 - Enable Form Autofill by default on Nightly. https://reviewboard.mozilla.org/r/136734/#review139834 Looks good. BTW, I'm going to rename the naming of `profiles` in the JSON file. After the renaming patch in bug 1359978 lands, the profile that users already save in storage will become unavailable. Should we wait for bug 1359978 or do you think we don't need to rename that entry in the JSON file?
Attachment #8865060 - Flags: review?(lchang) → review+
Depends on: 1362937
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/dfe330725cf7 Enable Form Autofill by default on Nightly. r=lchang
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0c35be45a41 Backed out changeset dfe330725cf7 for wpt failures in HTMLSelectElement interface: attribute autocomplete
Please autoland this if it gets r+
Comment on attachment 8865760 [details] Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test. https://reviewboard.mozilla.org/r/137374/#review140448 ::: testing/web-platform/meta/html/dom/interfaces.html.ini:3 (Diff revision 1) > [interfaces.html] > type: testharness > - prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true] > + prefs: [dom.forms.inputmode:true, dom.dialog_element.enabled:true, dom.forms.autocomplete.experimental:true] So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere.
Attachment #8865760 - Flags: review?(jjong) → review+
Comment on attachment 8865760 [details] Bug 1361560 - Force experimental autocomplete pref on during wpt DOM interface test. https://reviewboard.mozilla.org/r/137374/#review140448 > So "dom.forms.autocomplete.experimental" is to enable @autocomplete values other than "on/off", and also to enable @autocomplete attribute in `HTMLSelectElement`, right? Maybe we should add comments on that somewhere. Yes. Hmm… I can't figure out a way to add a comment to these .html.ini files… the usual semicolon methods gives an error and I can't find other examples of comments in those files. I'm going to land this without a comment. jgraham also gave r+ over IRC.
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c57b5d15190 Enable Form Autofill by default on Nightly. r=lchang https://hg.mozilla.org/integration/mozilla-inbound/rev/c7bfebd287aa Force experimental autocomplete pref on during wpt DOM interface test. r=jgraham,jessica
I think we can wait until bug 1340477 lands instead of fixing the wpt tests here.
Depends on: 1340477
Flags: needinfo?(MattN+bmo)
Attachment #8865760 - Attachment is obsolete: true
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e4724a00d2 Enable Form Autofill by default on Nightly. r=lchang
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: