Closed
Bug 1361590
Opened 8 years ago
Closed 8 years ago
Coverity report: nsMathMLmoFrame::nsMathMLmoFrame(nsStyleContext *): A scalar field is not initialized by the constructor
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | wontfix |
firefox54 | --- | wontfix |
firefox55 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: fredw)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, good-first-bug, regression, Whiteboard: [CID 750314])
Attachments
(1 file)
(deleted),
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Coverity CID 750314 Uninitialized scalar field
The field will contain an arbitrary value left over from earlier computations.
In nsMathMLmoFrame::nsMathMLmoFrame(nsStyleContext *): A scalar field is not initialized by the constructor
82protected:
2. uninit_member: Non-static class member mFlags is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member mMinSize is not initialized in this constructor nor in any functions that it calls.
CID 750314 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)6. uninit_member: Non-static class member mMaxSize is not initialized in this constructor nor in any functions that it calls.
83 explicit nsMathMLmoFrame(nsStyleContext* aContext) : nsMathMLTokenFrame(aContext) {}
84 virtual ~nsMathMLmoFrame();
85
86 nsMathMLChar mMathMLChar; // Here is the MathMLChar that will deal with the operator.
1. member_decl: Class member declaration for mFlags.
87 nsOperatorFlags mFlags;
3. member_decl: Class member declaration for mMinSize.
88 float mMinSize;
5. member_decl: Class member declaration for mMaxSize.
89 float mMaxSize;
http://searchfox.org/mozilla-central/rev/abe68d5dad139e376d5521ca1d4b7892e1e7f1ba/layout/mathml/nsMathMLmoFrame.h#83
Looks harmless, but we should init these three members to zero in the ctor anyway.
Updated•8 years ago
|
Blocks: coverity-analysis
Updated•8 years ago
|
Whiteboard: [CID 750314]
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8865112 -
Flags: review?(karlt)
Updated•8 years ago
|
Attachment #8865112 -
Flags: review?(karlt) → review?(mats)
Reporter | ||
Updated•8 years ago
|
Attachment #8865112 -
Flags: review?(mats) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec70344f616b
A scalar field is not initialized by the constructor. r=karlt
Keywords: checkin-needed
Comment 3•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
Assignee: nobody → fred.wang
status-firefox53:
--- → wontfix
status-firefox54:
--- → wontfix
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•