Closed
Bug 1362083
Opened 8 years ago
Closed 8 years ago
Toolbarbutton icons should be 16x16 rather than 18x18
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [photon-visual][p1])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-review-board-request
|
johannh
:
review+
|
Details |
No description provided.
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
No longer blocks: photon-visual
Assignee | ||
Comment 1•8 years ago
|
||
Needinfo shorlander to provide the modified icons.
Flags: needinfo?(shorlander)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.
https://reviewboard.mozilla.org/r/137270/#review140616
This seems good to me but there's an issue with the downloads indicator that I just mentioned to you (it gets larger on click), not sure if that's trivial to fix or not, so cancelling review for now.
Attachment #8865653 -
Flags: review?(jhofmann)
Comment hidden (mozreview-request) |
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.
https://reviewboard.mozilla.org/r/137270/#review140626
Looks good now, thanks.
Attachment #8865653 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3c404886f0f
Change toolbarbutton icon size from 18x18 to 16x16. r=johannh
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
Comment 10•8 years ago
|
||
Mozscreenshots found that this patch (at least I think it was this patch from looking at the pushlog) slightly stretched the back-button icon.
https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa
I guess it doesn't make a big difference visually and compact theme seems to be fine, I just wanted to note this. I'm not really sure how to follow up to this.
Assignee | ||
Comment 11•8 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #10)
> Mozscreenshots found that this patch (at least I think it was this patch
> from looking at the pushlog) slightly stretched the back-button icon.
>
> https://screenshots.mattn.ca/compare/?oldProject=mozilla-
> central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-
> central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa
>
> I guess it doesn't make a big difference visually and compact theme seems to
> be fine, I just wanted to note this. I'm not really sure how to follow up to
> this.
Icons generally shouldn't be stretched. Can you please file a new bug?
Flags: needinfo?(jhofmann)
You need to log in
before you can comment on or make changes to this bug.
Description
•