Closed
Bug 1362117
Opened 8 years ago
Closed 8 years ago
cairo_font_face_t's created from UnscaledFontFontconfig should hold a reference to the NativeFontResourceFontconfig that created them
Categories
(Core :: Graphics: Text, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr45 | --- | unaffected |
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: lsalzman)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Bad things happen if this isn't the case.
|
Reporter | |
Comment 1•8 years ago
|
||
This is responsible for a lot of test failures with PaintLayerBlob with WebRender
|
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → lsalzman
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8864589 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8864589 [details] [diff] [review]
keep NativeFontResourceFontconfig alive while its associated cairo_font_face_t is alive
Review of attachment 8864589 [details] [diff] [review]:
-----------------------------------------------------------------
Not beautiful, but it should work.
Attachment #8864589 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Updated•8 years ago
|
Blocks: 1355931
Severity: normal → critical
Status: NEW → ASSIGNED
Has Regression Range: --- → yes
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox-esr45:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Keywords: regression
OS: Unspecified → Linux
Priority: -- → P1
Hardware: Unspecified → All
Version: unspecified → 55 Branch
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7c9ede7c201
keep NativeFontResourceFontconfig alive while its associated cairo_font_face_t is alive. r=jrmuizel
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•