[:philipp] Reporter
	Description • 7 years ago

This bug was filed from the Socorro interface and is 
report bp-506367cd-9e54-4105-a46a-71cba0170504.
=============================================================

this new async shutdown timeout signature is newly showing up since firefox 53 from the work in bug 1293656. so better analysing crash reports might even trigger some more :-)

AsyncShutdownTimeout 	
{"phase":"profile-before-change","conditions":[{"name":"Crash reporter: blocking on minidump analysis","state":"(none)","filename":"c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/CrashReporterHost.cpp","lineNumber":95,"stack":"Minidump analysis"}]}

	Gabriele Svelto [:gsvelto]
	Comment 1 • 7 years ago

It seems like minidump analysis is taking too long while a regular shutdown is also taking place. I intend to rewrite the code in bug 1293656 in JavaScript as part of bug 1359326 so I might also add a provision to drop the minidump analysis if Firefox is shutting down.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 2 • 7 years ago

300 crashes or so here, per week, on release. Looks like a fix may be coming soon in bug 1359326.

	Gabriele Svelto [:gsvelto]
	Comment 3 • 7 years ago

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> 300 crashes or so here, per week, on release. Looks like a fix may be coming
> soon in bug 1359326.

Ouch. Well I do hope that bug 1359326 solves this by getting rid of the additional shutdown blocker, but if it doesn't (i.e. if we start timing out on the other blocker) then I might have to rethink how we handle this. I'm keeping my fingers crossed in the meantime, I should be able to land bug 1359326 next week after a last round of tests.

	Gabriele Svelto [:gsvelto]
	Comment 4 • 7 years ago

Now that bug 1359326 has landed keep your eyes peeled for crashes like this one but with the reason being "CrashService waiting for content crash ping to be sent". That's the other blocker in this code path and that one is still there and could take a long time.

If we get a spike of those then I think I'll have to drop any kind of minidump analysis for content crashes during shutdown and postpone it to the next startup.

	Gabriele Svelto [:gsvelto]
	Comment 5 • 6 years ago

Crash reports for this signature are only coming from users with old versions that don't have the fix in bug 1359326, closing.