See spec at https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/230998673 . Basically, we want to: - show the pocket item by default (in addition to the star) - provide context menu options to remove items from the location bar - provide context menu options in the menu to add options to the location bar

For-review patch with a test. The test checks the context menus in both the panel and urlbar. This patch also moves the click listener on the two bookmark star images up to the #star-button-box and add adds the context-menu-related attributes to #star-button-box too, instead of duplicating them on each image. Hope that doesn't screw up tests. We'll see.

Another thing is that currently right-clicks on the star button in the urlbar are incorrectly treated as left-clicks. This fixes that too. I think that was regressed in the bug that added the star button animation.

Forgot some awaits in the test.

Oh boy, looks like there were try failures on Windows because the mouse happened to be left over the urlbar popup in a subsequent test?

Let's try synthesizing a mousemove over the urlbar at the end of the test, plus a focus for good measure.

Try looks good this time.

Comment on attachment 8892706 [details] Bug 1363188 - Add an add/remove context menu to page actions in the urlbar. https://reviewboard.mozilla.org/r/163692/#review169130 ::: browser/base/content/test/urlbar/browser_page_action_menu.js:488 (Diff revision 3) > + type: "contextmenu", > + button: 2, > + }); > + await contextMenuPromise; > + > + // The context menu should show "Add from Address Bar". Click it. Nit: "Add to Address Bar" :-) ::: browser/base/content/test/urlbar/head.js:233 (Diff revision 3) > +function promisePanelEvent(panelIDOrNode, eventType) { > return new Promise(resolve => { > - gPageActionPanel.addEventListener(name, () => { > + let panel = typeof(panelIDOrNode) != "string" ? panelIDOrNode : > + document.getElementById(panelIDOrNode); > + if (!panel || > + (eventType == "popupshowing" && panel.state == "open") || Nothing passes `popupshowing`. Did you mean `popupshown` ? Do we need this check?

(In reply to :Gijs from comment #13) > ::: browser/base/content/test/urlbar/head.js:233 > (Diff revision 3) > > +function promisePanelEvent(panelIDOrNode, eventType) { > > return new Promise(resolve => { > > - gPageActionPanel.addEventListener(name, () => { > > + let panel = typeof(panelIDOrNode) != "string" ? panelIDOrNode : > > + document.getElementById(panelIDOrNode); > > + if (!panel || > > + (eventType == "popupshowing" && panel.state == "open") || > > Nothing passes `popupshowing`. Did you mean `popupshown` ? Do we need this > check? Ah yeah, I meant popupshown, thanks. I copied and pasted this from browser_PageActions.js, so I fixed that there, too.

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47cc4909098d Add an add/remove context menu to page actions in the urlbar. r=Gijs

Verified on Windows, Mac, and Ubuntu.