__defineGetter__ and __defineSetter__ are deprecated, and their use on top level |this| objects in .jsms gets in the way of bug 1186409, because |this| ends up not being a top-level window, so it doesn't have that method on it. I also fixed a few other places that were in the same file as uses on top-level this to avoid introducing too much inconsistency. I think this is really only needed for the one place I changed this that is in a .jsm. I set configurable and enumerable to true. This seems to be how the old ones are defined per the ECMAScript spec: https://tc39.github.io/ecma262/#sec-additional-ecmascript-features-for-web-browsers Also, this is required to avoid some test failures of the form "test left unexpected property on window" because things like the getter for AddonManager in browser/base/content/browser.js delete the existing property and replace it with a normal one (which is enumerable), so you have to make sure the original getter is also enumerable.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0174293131420623c1b34f1bc20ceba815d9e114

Comment on attachment 8865948 [details] Bug 1363215 - Replace calls to __define{Getter,Setter}__ on top-level this with Object.defineProperty. https://reviewboard.mozilla.org/r/137532/#review140796

Florian, do we have a bug on switching over to the new/standards syntax and making __define* an eslint error?

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96dd2e2d8d16 Replace calls to __define{Getter,Setter}__ on top-level this with Object.defineProperty. r=Gijs

(In reply to :Gijs from comment #4) > Florian, do we have a bug on switching over to the new/standards syntax and > making __define* an eslint error? Not that I'm aware of. That's likely scriptable, although the result will be unfortunate where the current version fits on a single line.

Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eab436c452e9 Replace calls to __define{Getter,Setter}__ on top-level this with Object.defineProperty. r=Gijs