Closed
Bug 1363457
Opened 8 years ago
Closed 8 years ago
Remove GeckoApp.getEventDispatcher()
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
droeh
:
review+
|
Details | Diff | Splinter Review |
GeckoApp.getEventDispatcher() uses GeckoInterface to get the current GeckoApp. We should just remove it and use GeckoApp.getAppEventDispatcher() in the future.
|
Assignee | |
Comment 1•8 years ago
|
||
Remove GeckoInterface.getAppEventDispatcher(), which is actually no
longer called by anyone. r=me for trivial patch.
Attachment #8868687 -
Flags: review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
Use the current Activity to derive GeckoApp instances in tests, so we
no longer need GeckoApp.getEventDispatcher() at all.
Also refactor some code for getting an Activity from Context in
FindInPageBar and FormAssistPopup.
Attachment #8868702 -
Flags: review?(droeh)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8868702 [details] [diff] [review]
2. Remove GeckoApp.getEventDispatcher() (v1)
Review of attachment 8868702 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #8868702 -
Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ba0313fbff
1. Remove GeckoInterface.getAppEventDispatcher(); r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/623036d074b4
2. Remove GeckoApp.getEventDispatcher(); r=droeh
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a8ba0313fbff
https://hg.mozilla.org/mozilla-central/rev/623036d074b4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 55 → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•