Closed
Bug 1363490
Opened 7 years ago
Closed 7 years ago
Assertion failure: !mInStyleRefresh [@ mozilla::RestyleManager::ContentStateChangedInternal]
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: tsmith, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
Assertion failure: !mInStyleRefresh, at /home/worker/workspace/build/src/layout/base/RestyleManager.cpp:334 #0 0x7fa902971b7a in mozilla::RestyleManager::ContentStateChangedInternal(mozilla::dom::Element*, mozilla::EventStates, nsChangeHint*, nsRestyleHint*) /home/worker/workspace/build/src/layout/base/RestyleManager.cpp:367:15 #1 0x7fa9029712de in mozilla::GeckoRestyleManager::ContentStateChanged(nsIContent*, mozilla::EventStates) /home/worker/workspace/build/src/layout/base/GeckoRestyleManager.cpp:216:3 #2 0x7fa9029aa5de in mozilla::PresShell::ContentStateChanged(nsIDocument*, nsIContent*, mozilla::EventStates) /home/worker/workspace/build/src/layout/base/PresShell.cpp:4285:37 #3 0x7fa8ff61491d in nsDocument::ContentStateChanged(nsIContent*, mozilla::EventStates) /home/worker/workspace/build/src/dom/base/nsDocument.cpp:5413:3 #4 0x7fa8ff485af7 in mozilla::dom::Element::UpdateState(bool) /home/worker/workspace/build/src/dom/base/Element.cpp:236:14 #5 0x7fa8ff48085a in mozilla::dom::Element::SetDirectionality(mozilla::Directionality, bool) /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Element.h:419:7 #6 0x7fa8ff481291 in mozilla::SetAncestorDirectionIfAuto(nsTextNode*, mozilla::Directionality, bool) /home/worker/workspace/build/src/dom/base/DirectionalityUtils.cpp:815:17 #7 0x7fa8ff7440d3 in nsTextNode::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool) /home/worker/workspace/build/src/dom/base/nsTextNode.cpp:146:3 #8 0x7fa902a15cf2 in nsCSSFrameConstructor::GetAnonymousContent(nsIContent*, nsIFrame*, nsTArray<nsIAnonymousContentCreator::ContentInfo>&) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:4270:19 #9 0x7fa902a16f08 in nsCSSFrameConstructor::ConstructSelectFrame(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItem&, nsContainerFrame*, nsStyleDisplay const*, nsFrameItems&) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:3164:30 #10 0x7fa902a1aab8 in nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsContainerFrame*, nsFrameItems&) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:3898:7 #11 0x7fa902a211a0 in nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsContainerFrame*, nsFrameItems&) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:6256:3 #12 0x7fa902a0efd5 in nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsContainerFrame*, nsFrameItems&) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:10877:5 #13 0x7fa902a271a1 in nsCSSFrameConstructor::ContentRangeInserted(nsIContent*, nsIContent*, nsIContent*, nsILayoutHistoryState*, bool, bool, TreeMatchContext*) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:8286:3 #14 0x7fa902a21d42 in nsCSSFrameConstructor::RecreateFramesForContent(nsIContent*, bool, nsCSSFrameConstructor::RemoveFlags, nsIContent**) /home/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:9941:9 ... see log.txt
Flags: in-testsuite?
Reporter | ||
Comment 1•7 years ago
|
||
Updated•7 years ago
|
Component: DOM → CSS Parsing and Computation
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Comment 2•7 years ago
|
||
Noted in bug 1386905 that the fix there should also fix this. I was able to use the testcase from there to reproduce this crash in m-c 20170802-52285ea5e54c, and not in m-c 20170811-65826179c86e.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
status-firefox55:
--- → wontfix
status-firefox56:
--- → fixed
status-firefox57:
--- → fixed
status-firefox-esr52:
--- → affected
Depends on: 1386905
Target Milestone: --- → mozilla57
Comment 3•7 years ago
|
||
Do we want to land this testcase as a crashtest still or will the one from bug 1386905 suffice?
Flags: needinfo?(twsmith)
Reporter | ||
Comment 4•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3) > Do we want to land this testcase as a crashtest still or will the one from > bug 1386905 suffice? I think the other test case should do the job.
Flags: needinfo?(twsmith)
Flags: in-testsuite?
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•