Closed Bug 1363497 Opened 7 years ago Closed 7 years ago

Expose react-addons-perf from console launchpad

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Iteration:
55.5 - May 15
Tracking Status
firefox55 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [console-html])

Attachments

(1 file)

This only works with the dev version of react, but we can add a new npm command to explicitly use dev, and make npm start use prod by default.
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Priority: -- → P1
Comment on attachment 8866033 [details] Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`; https://reviewboard.mozilla.org/r/137632/#review140976 Just a small nit but this looks good to me ::: devtools/client/webconsole/package.json:9 (Diff revision 1) > "engines": { > "node": ">=6.9.0" > }, > "scripts": { > - "start": "node bin/dev-server", > + "start": "cross-env NODE_ENV=production node bin/dev-server", > + "dev": "node bin/dev-server", nit: What do you think of naming this `start-dev` or something alike, so it looks like the original start command ?
Attachment #8866033 - Flags: review?(nchevobbe) → review+
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e204f93b4a39 Include react-addons-perf for launchpad via `npm run dev`;r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: