Closed
Bug 1363666
Opened 8 years ago
Closed 8 years ago
stylo: Allow llvm 4.0 for stylo
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
The latest bindgen update fixed the bugs that prevented it from being used, AFAICT.
Comment hidden (mozreview-request) |
Comment on attachment 8866267 [details]
Bug 1363666: Remove more LLVM version requirements for stylo.
https://reviewboard.mozilla.org/r/137888/#review141024
::: toolkit/moz.configure:622
(Diff revision 1)
>
> @imports(_from='textwrap', _import='dedent')
> def check_minimum_llvm_config_version(llvm_config):
> version = Version(invoke_llvm_config(llvm_config, '--version'))
> min_version = Version('3.9.0')
> # For various reasons, bindgen doesn't work with LLVM 4.0.x.
Is this comment still necessary?
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Jan Beich from comment #2)
> Comment on attachment 8866267 [details]
> Bug 1363666: Remove more LLVM version requirements for stylo.
>
> https://reviewboard.mozilla.org/r/137888/#review141024
>
> ::: toolkit/moz.configure:622
> (Diff revision 1)
> >
> > @imports(_from='textwrap', _import='dedent')
> > def check_minimum_llvm_config_version(llvm_config):
> > version = Version(invoke_llvm_config(llvm_config, '--version'))
> > min_version = Version('3.9.0')
> > # For various reasons, bindgen doesn't work with LLVM 4.0.x.
>
> Is this comment still necessary?
It is not, good catch.
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8866267 [details]
Bug 1363666: Remove more LLVM version requirements for stylo.
https://reviewboard.mozilla.org/r/137888/#review141152
rs=me, assuming that bindgen DTRT.
::: toolkit/moz.configure:626
(Diff revision 2)
> - if version < min_version or (version >= Version('4.0.0') and
> - version < Version('5.0.0')):
> die(dedent('''\
> llvm installation {} is incompatible with Stylo bindgen.
>
> - To compile Stylo, please install version {} of
> + To compile Stylo, please install version {}+ of
Maybe say "version {} or higher..." here for clarity.
Attachment #8866267 -
Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•8 years ago
|
||
hg error in cmd: hg rebase -s 43da2435228b -d 3b02ca42da3a: abort: can't rebase public changeset 43da2435228b
(see 'hg help phases' for details)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ff09d3c3180d
Remove more LLVM version requirements for stylo. r=froydnj
Comment 10•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
Assignee: nobody → emilio+bugs
Comment 11•8 years ago
|
||
It seems LLVM 4.0 works on Windows build as well. I guess we can start moving people to use 4.0 by default. If all people can move to 4.0, we can remove workarounds for old version like nsTArrayBorrowed.
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8866267 [details]
Bug 1363666: Remove more LLVM version requirements for stylo.
https://reviewboard.mozilla.org/r/137888/#review141474
::: toolkit/moz.configure:622
(Diff revisions 2 - 3)
>
> @imports(_from='textwrap', _import='dedent')
> def check_minimum_llvm_config_version(llvm_config):
> version = Version(invoke_llvm_config(llvm_config, '--version'))
> min_version = Version('3.9.0')
> + # For various reasons, bindgen doesn't work with LLVM 4.0.x.
Can you remove the comment again?
Comment 13•8 years ago
|
||
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7986e8790db6
followup - Remove outdated comment. r=me
Assignee | ||
Comment 14•8 years ago
|
||
(In reply to Jan Beich from comment #12)
> Comment on attachment 8866267 [details]
> Bug 1363666: Remove more LLVM version requirements for stylo.
>
> https://reviewboard.mozilla.org/r/137888/#review141474
>
> ::: toolkit/moz.configure:622
> (Diff revisions 2 - 3)
> >
> > @imports(_from='textwrap', _import='dedent')
> > def check_minimum_llvm_config_version(llvm_config):
> > version = Version(invoke_llvm_config(llvm_config, '--version'))
> > min_version = Version('3.9.0')
> > + # For various reasons, bindgen doesn't work with LLVM 4.0.x.
>
> Can you remove the comment again?
Gah, that's the patch mozreview couldn't rebase. Done, thanks again
Comment 15•8 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•