Closed
Bug 1363689
Opened 8 years ago
Closed 8 years ago
Have gBrowser.loadTabs() provide a valid triggeringPrincipal
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ckerschb
Blocks: 1362329
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
|
|
Assignee | |
Comment 1•8 years ago
|
||
Gijs, similar to bug 1363687 we would like tests to pass a triggeringPrincipal for loadTabs(). Please note that I also updated tabbrowser.xml to pass on that principal to addTab(...) or also loadURIWithFlags within tabbrowser.xml.
Attachment #8866327 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8866327 [details] [diff] [review]
bug_1363689_loadtabs_triggeringPrincipal.patch
Review of attachment 8866327 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/sessionstore/test/browser_522545.js
@@ +207,5 @@
> runNextTest();
> }
>
> + gBrowser.loadTabs(uris, {
> + triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()
nit; trailing comma
::: testing/talos/talos/tests/tabswitch/bootstrap.js
@@ +85,5 @@
> function loadTabs(gBrowser, urls) {
> return new Promise((resolve) => {
> + gBrowser.loadTabs(urls, {
> + inBackground: true
> + triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal()
Trailing commas missing here and the line before.
Attachment #8866327 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c58392f950f
Have gBrowser.loadTabs() provide a valid triggeringPrincipal. r=gijs
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•