Closed Bug 1363692 Opened 8 years ago Closed 7 years ago

Broken key navigation in the URL drop-down in high contrast theme

Categories

(Firefox :: Address Bar, defect, P1)

55 Branch
All
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: sbadau, Assigned: adw)

References

Details

(Keywords: regression, Whiteboard: [fxsearch])

[Affected versions]: - Nightly 55.0a1 [Affected platforms]: - Windows 7 [Pre-reguisites]: - Enable a high contrast theme (right click on your Desktop -> Personalize -> from Basic and High Contrast Theme, choose a high contrast theme) [Steps to reproduce]: 1. Launch Firefox 2. Type "moz" in the URL bar 3. Press the down arrow key to navigate through the autocomplete results and one-offs [Expected result]: - Navigation is properly done, the autocomplete results and one-offs are selected one by one. [Actual result]: - Navigation is broken, even if in the URL bar you see the links changing (as you hit the down arrow key), the selection does not follow the links. Please see the screencast for more details: https://www.screencast.com/t/QZGGXqqKXAN [Regression range]: - https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7bf9443be2c4a5187c37440e35f3526148d7fa8&tochange=37a5b7f6f101df2eb292b1b6baaf1540c9920e20 [Additional notes]: - I could not reproduce this issue on Windows 10. - I'll try to reproduce this issue on Windows 8 as soon as possible and post back the results.
Whiteboard: [fxsearch]
I'm not sure what's going on here, but if it's just a coloring problem, the patch in bug 1363407 might fix this since it makes all Windows themes use Highlight as the selected item background color. Right now we only set the color for the default Windows theme. Unless I'm missing something it looks like we just don't set a color at all for non-default themes.
Simona, could you try to reproduce this now that bug 1363407 was fixed?
Flags: needinfo?(simona.marcu)
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 Build ID: 20170515030205 Panos, I can no longer reproduce this issue on the latest Nightly 55.0a1.
Flags: needinfo?(simona.marcu)
Thank you Simona! Marking this as fixed then.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1363407
Resolution: --- → FIXED
Assignee: nobody → adw
Target Milestone: --- → Firefox 55
Verified as fixed using the latest Nightly 55.0a1 (Build ID: 20170518030213) on Windows 10 x64 and Windows 7 x64.
Status: RESOLVED → VERIFIED
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.