Closed Bug 1363696 Opened 8 years ago Closed 8 years ago

Compute the indent of a message in the message add reducer

Categories

(DevTools :: Console, enhancement, P1)

Product:
DevTools
Component:
Console
Type:
enhancement

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: nchevobbe, Assigned: Honza)

References

Details

(Whiteboard: [console-html])

Attachments

(1 file)

Bug 1363696 - Compute the indent of a message in the message add reducer;
(deleted), text/x-review-board-request
nchevobbe
: review+
Details
At the moment, we get the length of the parent groups of the message in ConsoleOutput. This should be done at earlier stage and put into the message object since it isn't a property that will change.
Priority: -- → P2
Whiteboard: [console-html]
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.6 - May 29
Comment on attachment 8871359 [details] Bug 1363696 - Compute the indent of a message in the message add reducer; https://reviewboard.mozilla.org/r/142830/#review146792 Looking good, thanks Honza !
Attachment #8871359 - Flags: review?(nchevobbe) → review+
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac956e9a5d32 Compute the indent of a message in the message add reducer; r=nchevobbe
Backed out for eslint failure at devtools/client/webconsole/new-console-output/components/console-output.js:85: https://hg.mozilla.org/integration/autoland/rev/757120797ede591897b778d35fc49d0addfd6a1c Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ac956e9a5d32b82c7a0d9d6436b605f0705820fc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=102256195&repo=autoland > TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/client/webconsole/new-console-output/components/console-output.js:85:7 | 'groups' is assigned a value but never used. (no-unused-vars)
Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dbd37535672 Compute the indent of a message in the message add reducer; r=nchevobbe
Sorry about that. I fixed the problem and new try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ab02ba10cc30bea3a6705cdcd66cca7bcccdc2 Trying to land again. Honza
Flags: needinfo?(odvarko)
https://hg.mozilla.org/mozilla-central/rev/2dbd37535672
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: