Closed
Bug 1363768
Opened 7 years ago
Closed 7 years ago
Cache and simplify some components under Message
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox55 fixed)
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
(Whiteboard: [console-html])
Attachments
(1 file)
Doing some measurements, it looks like there are some easy small wins with MessageIndent, MessageRepeat, and MessageIcon
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8866629 [details]
Bug 1363768 - Prevent creating constant elements during render;
https://reviewboard.mozilla.org/r/138234/#review141464
Just a small thing, but R+ if TRY and mocha are green
::: devtools/client/webconsole/new-console-output/components/message.js:194
(Diff revision 1)
> )));
> } else {
> notesNodes = [];
> }
>
> - const repeat = MessageRepeat({repeat: this.props.repeat});
> + const repeat = this.props.repeat ? MessageRepeat({repeat: this.props.repeat}) : null;
IF we're doing this here, we can go a little further and do not print anything if repeat is < 2
```
const repeat = this.props.repeat && this.props.repeat > 1
? MessageRepeat({repeat: this.props.repeat})
: null;
```
It also means that we can remove tis logic from the MessageRepeat function
Attachment #8866629 -
Flags: review?(nchevobbe) → review+
Updated•7 years ago
|
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Priority: -- → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Thanks, good points. Updated, and pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e3fe814e311328fe69e35702eaad0f0d6f3ef04
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bea7660031a0
Prevent creating constant elements during render;r=nchevobbe
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•