Closed
Bug 1363869
Opened 8 years ago
Closed 7 years ago
Increase vertical padding of toolbar buttons
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
People
(Reporter: nhnt11, Assigned: nhnt11)
References
Details
(Whiteboard: [photon-visual][p1][57])
Attachments
(1 file)
No description provided.
Updated•8 years ago
|
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8866537 [details]
Bug 1363869 - Increase vertical padding of toolbar buttons.
https://reviewboard.mozilla.org/r/138154/#review141314
--toolbarbutton-vertical-inner-padding is used in quite a few more places than this patch touches. Shouldn't they all switch to --toolbarbutton-inner-padding for photon?
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8866537 [details]
Bug 1363869 - Increase vertical padding of toolbar buttons.
https://reviewboard.mozilla.org/r/138154/#review141668
Attachment #8866537 -
Flags: review?(dao+bmo)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8866537 [details]
Bug 1363869 - Increase vertical padding of toolbar buttons.
https://reviewboard.mozilla.org/r/138154/#review141314
So, to make it a bit simpler, I changed the name of the variable to just --toolbarbutton-inner-padding, and put the two different values (before/after photon) in ifdefs. What do you think? I figured this is cleaner than a bunch of ifdefs everywhere.
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8866537 [details]
Bug 1363869 - Increase vertical padding of toolbar buttons.
https://reviewboard.mozilla.org/r/138154/#review143024
::: browser/extensions/pocket/skin/osx/pocket.css:4
(Diff revision 2)
> @import url("chrome://pocket-shared/skin/pocket.css");
>
> #nav-bar #pocket-button > .toolbarbutton-icon {
> +%ifdef MOZ_PHOTON_THEME
I don't think this file is currently preprocessed, so this doesn't work.
Attachment #8866537 -
Flags: review?(dao+bmo) → review-
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8866537 [details]
Bug 1363869 - Increase vertical padding of toolbar buttons.
https://reviewboard.mozilla.org/r/138154/#review143026
Attachment #8866537 -
Flags: review?(dao+bmo) → review+
Comment 10•7 years ago
|
||
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/738b18369999
Increase vertical padding of toolbar buttons. r=dao
Updated•7 years ago
|
Iteration: 55.5 - May 15 → 55.6 - May 29
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
Comment 11•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 12•7 years ago
|
||
Screenshots:
https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=b8e9b674033bcd1f3a4c59b9d0ee7619c1a17cc5&newProject=mozilla-central&newRev=985b3ee939338022ef44028b5251f77af19c3638
Seems to be missing screenshots from Windows, unfortunately (and OSX has been gone for a couple of days, too). Should be fine, though.
Updated•7 years ago
|
Comment 13•7 years ago
|
||
Nihanth can you suggest me how to verify this bug? Thanks
Flags: needinfo?(nhnt11)
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to ovidiu boca[:Ovidiu] from comment #13)
> Nihanth can you suggest me how to verify this bug? Thanks
Bah, I forgot to reply to this. I've been in touch with Brindusa on other channels though, here's the gist:
This bug adds padding to the top and bottom of toolbar button icons. Before this landed, the buttons were rectangular. After this landed, they should be square.
Flags: needinfo?(nhnt11)
Comment 15•7 years ago
|
||
I verified this on Mac OS X 10.10, Mac OS X 10.12, Windows 10, Windows 7, Ubuntu 16.04 with the latest Nightly 57.0a1(2017-08-15) and I can confirm the fix, the buttons are square.
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•