Closed
Bug 1363970
Opened 8 years ago
Closed 5 years ago
Color picker doesn't work/move in RDM, when touch is enabled.
Categories
(DevTools :: Responsive Design Mode, defect, P2)
Tracking
(firefox57 wontfix, firefox71 verified)
VERIFIED
FIXED
Firefox 71
People
(Reporter: dehghani.m.c, Assigned: mtigley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [dt-q])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Hello,
FF 53.0.2
e10s: enabled
Windows: 10 x64
In new RDM, when touch simulation is enabled, the Inspector's color picker doesn't move (lock in somewhere in the screen), but after toggling touch simulation (turn that off) it works again.
Mehdi
Thanks for the report! I can reproduce the issue.
status-firefox57:
--- → fix-optional
Priority: -- → P2
Blocks: rdm-touch
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
||
Comment 2•6 years ago
|
||
It also dont work when you resize the screen.
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Whiteboard: [dt-q]
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•5 years ago
|
||
Since we're picking from the page while RDM's touch simulation is active, it's likely the touch-simulator will need to bail out before the touch event is handled. This would be the same approach done for Bug 1409085.
If that's the case we'll need to tell RDM to disable touch events depending on the color picker state.
Places where the color picker is being enabled: https://dxr.mozilla.org/mozilla-central/search?q=pickColorFromPa&redirect=false
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/570912314438
Disable touch simulation when color picker is active. r=gl,rcaliman
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
|
||
Updated•5 years ago
|
Flags: qe-verify+
|
||
Comment 9•5 years ago
|
||
Confirmed issue with 58.0a1 (2017-10-26) on Windows 10.
Verified fix with 71.0b5 on Windows 10, Ubuntu 18.04 and 71.0b3 on macOS 10.14.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Hardware: Unspecified → All
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•