Closed Bug 1364059 Opened 8 years ago Closed 8 years ago

Crash in CompareNetwork::NetworkFinished

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 blocking fixed

People

(Reporter: marco, Assigned: bhsu)

References

Details

(Keywords: crash)

Crash Data

This bug was filed from the Socorro interface and is report bp-e0365253-7e90-4d49-af29-e36590170511. ============================================================= Probably due to bug 1290951.
HoPang, it seems maybe we could be in one of the other states if aRv is not NS_OK here: https://dxr.mozilla.org/mozilla-central/source/dom/workers/ServiceWorkerScriptCache.cpp#810 What do you think? I'll try to make a patch since its night in Taipei now.
See comment 1.
Flags: needinfo?(bhsu)
Crash Signature: [@ CompareNetwork::NetworkFinished] → [@ CompareNetwork::NetworkFinished] [@ mozilla::dom::workers::serviceWorkerScriptCache::`anonymous namespace''::CompareNetwork::NetworkFinished]
I backed bug 1290951 out from m-c so we could respin nightlies. This was causing insta-crashes on GMail.
Assignee: nobody → bhsu
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: affected → fixed
Flags: needinfo?(bhsu)
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
tracking-firefox55: --- → blocking
OS: Linux → All
Hardware: Unspecified → All
Seems its likely in this state: WaitingForScriptOrComparisonResult I still think we should just accept any state if the result is NS_FAILED(aRv), though.
You need to log in before you can comment on or make changes to this bug.