Closed
Bug 1364653
Opened 8 years ago
Closed 8 years ago
Port bug 1356507 to TB [Show version and updater in the preferences update pane]
Categories
(Thunderbird :: Preferences, enhancement)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
FX introduced the version info and the update check in the preferences. If the user is already there to config the update policy, he can now directly check if a update is available.
Assignee | ||
Comment 1•8 years ago
|
||
Magnus, what do you think, do we want this? I think at least the version info is handy.
I could also add a switch to show the update row only in the in-content prefs.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8867448 -
Flags: review?(mkmelin+mozilla)
Comment 2•8 years ago
|
||
I'll jump in from a support perspective to say I agree with the rationale starting at bug 1356507 comment 5, and I believe we should do this Thunderbird. (And too bad we didn't do it years ago)
Assignee | ||
Comment 3•8 years ago
|
||
Added showing the BuildID also in the about dialog.
Attachment #8867448 -
Attachment is obsolete: true
Attachment #8867448 -
Flags: review?(mkmelin+mozilla)
Attachment #8869820 -
Flags: review?(mkmelin+mozilla)
Updated•8 years ago
|
Attachment #8869820 -
Flags: review?(mkmelin+mozilla) → review?(jorgk)
Comment 4•8 years ago
|
||
Comment on attachment 8869820 [details] [diff] [review]
updatePref.patch
I find it a bit sad that FF decided not to include the complete build ID (with the time). That could be useful. Anyway, we follow that. Or would you consider showing the full thing, for example:
Build ID : 20170517030204
Is that available elsewhere in the UI?
Attachment #8869820 -
Flags: review?(jorgk) → review+
Assignee | ||
Comment 5•8 years ago
|
||
The time is available in the troubleshooting info's. I think, this would make sense when multiple Dailies per day would be produced. The prefs interface is to show the user there is a update available and not for version info when he has troubles.
Keywords: checkin-needed
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #6)
> https://hg.mozilla.org/comm-central/diff/abc0bcd3caec/mail/locales/en-US/chrome/messenger/preferences/advanced.dtd#l1.24
>
> +<!ENTITY updateApp.version.pre "Version ">
(In reply to Francesco Lodolo [:flod] from bug 1356507 comment 40)
> > <!ENTITY updateApplication.label "&brandShortName; Updates">
> > +<!ENTITY updateApplication.version "Version ">
>
> a) a localization note explaining it, so localizers will know why the space
> is needed
Note that TB currently appears to display 2 spaces in a row in the Update tab ("Version 55.0a1"), as if a hardcoded one is also included in addition to the one in the string. This doesn’t clearly strike in Firefox due to its in-content prefs (or in TB when enabling them), but it certainly does in TB’s default pref dialog/pane.
In other words: are you sure the additional one is required in this string or should the hardcoded one be removed, if possible? (For consistency, changing this both in TB and FF would be nice.)
Assignee | ||
Comment 8•8 years ago
|
||
It's needed. What is needed is a
#version {
margin-inline-start: 0;
}
It could be a !important is needed for macOS. But I need to check this.
You need to log in
before you can comment on or make changes to this bug.
Description
•