Closed Bug 1364702 Opened 8 years ago Closed 8 years ago

Forward button looks like Back button in RTL locales

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.5 - May 15
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: itiel_yn8, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [photon-visual][p1])

Attachments

(2 files)

Forward button reversed.png
(deleted), image/png
Details
Bug 1364702 - [RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css).
(deleted), text/x-review-board-request
johannh
: review+
Details
Attached image Forward button reversed.png (deleted) —
See attached. The left button (Forward in RTL locales) should point left. The right button (Back) is okay. This is a regression of bug 1363840 according to Mozregression.
Assignee: nobody → dao+bmo
Whiteboard: [photon-visual][p1]
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Priority: -- → P1
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
Comment on attachment 8867496 [details] Bug 1364702 - [RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css). https://reviewboard.mozilla.org/r/139038/#review142444
Attachment #8867496 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c10971e1e4f3 [RTL] mirror the back button in toolbarbutton-icons.inc.css like other buttons, and also mirror the forward button for Photon (non-Photon forward button is handled in browser.css). r=johannh
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Version: unspecified → 55 Branch
https://hg.mozilla.org/mozilla-central/rev/c10971e1e4f3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I managed to reproduce the issue on an older Nightly 55.0a1 RTL build (2017-05-12) using Windows 10 x64. The issue doesn't reproduce anymore on the latest Nightly 55.0a1 RTL build (2017-05-16) across platforms: Windows 10 x64, Ubuntu 16.04 LTS x64 and Mac OS X 10.12.5.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: