Closed
Bug 1364878
Opened 7 years ago
Closed 7 years ago
All extensions are force enabled and marked as disabled in about:addons & about:support after landing patches from bug #1358846
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | + | verified |
People
(Reporter: Virtual, Assigned: kmag)
References
(Blocks 1 open bug)
Details
(Keywords: nightly-community, regression)
Attachments
(1 file)
[Tracking Requested - why for this release]: Regression
STR:
1. Update Mozilla Firefox Nightly 55.0a1 to (2017-05-15) build from (2017-05-14) build
2. Open about:addons or about:support
3. See that all extensions are force enabled and marked as disabled
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 1•7 years ago
|
||
"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-14-03-02-07-mozilla-central/
Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-15-03-02-05-mozilla-central/
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73b3fc64525b6816842c737e104ef2ac5482d217&tochange=e66dedabe582ba7b394aee4f89ed70fe389b3c46
Has STR: --- → yes
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 2•7 years ago
|
||
Looking on regression range, I suspect that this issue is probably caused by:
Bug #1356826 - Get rid of directory scans, and especially recursive directory scan, at startup
Blocks: 1356826
Component: Untriaged → Add-ons Manager
Flags: needinfo?(kmaglione+bmo)
Product: Firefox → Toolkit
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 3•7 years ago
|
||
Bug #1361900 - Use script precompiler in content processes
could be other cause.
Blocks: 1361900
In my case, after re-enabling / re-disabling most of my extensions, I can no longer disable those extensions that are marked as not multiprocess compatible. It is because there was no "enable" button to begin with for these extensions when e10s is enabled.
Also, NoScript cannot be disabled even if I explicitly try to disable it a few times.
Comment 5•7 years ago
|
||
(In reply to Fanolian from comment #4)
> Also, NoScript cannot be disabled even if I explicitly try to disable it a
> few times.
The same problem occurs with Greasemonkey.
Comment 7•7 years ago
|
||
I disabled nightly updates for now until we find the last good last build to point users to. Will send an email to r-d in a bit.
Comment 8•7 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #5)
> (In reply to Fanolian from comment #4)
> > Also, NoScript cannot be disabled even if I explicitly try to disable it a
> > few times.
>
> The same problem occurs with Greasemonkey.
Same problem with Tab Mix Plus and Yet Another Smooth Scrolling. However, I can enable or disable AdBlock Plus, uBlock Origin and Session Manager. It looks like all e10s-compatible non-jetpack addons can't disabled.
Comment 9•7 years ago
|
||
There are a bunch of these messages during startup:
Disabling foreign installed add-on {72b2e02b-3a71-4895-886c-fd12ebe36ba3} in app-profile
ie, extensions are being erroneously marked as having been sideloaded.
My money is on bug 1358846. I haven't looked at those patches, they are enormous. But this would be consistent with not propagating the bit for sideloaded addons while migrating.
Comment 10•7 years ago
|
||
Kris, could you confirm that the patch in bug 1358846 are the ones that caused this bug?
Flags: needinfo?(kmaglione+bmo)
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8867773 -
Flags: review?(aswan) → review?(rhelmer)
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8867773 [details]
Bug 1364878: Fix add-on path migration issues.
https://reviewboard.mozilla.org/r/139310/#review142608
Do we need to bump the schema version too?
Attachment #8867773 -
Flags: review?(rhelmer) → review+
Assignee | ||
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e803c515c7a7f8c90b0f2bc0e997bb9865052a6
Bug 1364878: Fix add-on path migration issues. r=rhelmer
Comment 14•7 years ago
|
||
Can we write a test for this?
Flags: in-testsuite?
Keywords: regressionwindow-wanted
Assignee | ||
Comment 15•7 years ago
|
||
I'm looking into it, but we don't have any good tools for writing DB migration tests, so I'm going to do it as a follow-up.
Flags: needinfo?(kmaglione+bmo)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Assignee: nobody → kmaglione+bmo
Blocks: 1358846
Status: NEW → ASSIGNED
Has Regression Range: --- → yes
Comment 16•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1365256
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 18•7 years ago
|
||
FYI - The followup is being tracked in the bug #1365256, as the issue wasn't fixed completely.
Comment 19•7 years ago
|
||
Updates for Nightly are now re-enabled.
Comment 20•7 years ago
|
||
Linux updates weren't working until just now, see bug 1365508.
Comment 21•7 years ago
|
||
We spot-checked a few update flows from May 14 and May 15 Nightly build, to latest Nightly build, across platforms and some of the most popular locales. Checking that a handful of add-ons work as expected after the update was also part of our test coverage.
Apart from Bug 1364934, which we encountered consistently on macOS 10.12.4 using Nightly builds from May 15+, all of our tests passed.
Detailed test results are available in this etherpad [1], while the broken scenarios we identified as affected by Bug 1364934 have been listed in that bug.
[1] https://public.etherpad-mozilla.org/p/1364878-sv
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 22•7 years ago
|
||
I'm confirming that this issue is fixed, starting from Mozilla Firefox Nightly 55.0a1 (2017-05-18) [with followups: bug #1365256 and bug #1365706].
Status: RESOLVED → VERIFIED
Summary: All extensions are force enabled and marked as disabled in about:addons & about:support in Mozilla Firefox Nightly 55.0a1 (2017-05-15) → All extensions are force enabled and marked as disabled in about:addons & about:support after landing patches from bug #1358846
Comment 23•7 years ago
|
||
And probably follow-up bug 1365568
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1365568
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•