Markus Stange [:mstange] Reporter
	Description • 7 years ago

See the screenshot. It looks to me like the refresh icon is a little too far to the right.

	Johann Hofmann [:johannh]
	Comment 1 • 7 years ago

So it seems that the icon itself is a little offset (navigate to chrome://browser/skin/reload.svg). I think it's not worth fixing this in Nightly until we do bug 1355455.

Thanks :)

	Dão Gottwald [:dao]
	Comment 2 • 7 years ago

Better keep this open to make sure we actually end up fixing this.

	Dão Gottwald [:dao]
	Comment 3 • 7 years ago

I think the icon is still leaning a bit to the right. Markus, can you confirm?

Stephen, what do you think?

	Dão Gottwald [:dao]
	Comment 4 • 7 years ago

Alas, if we want to do anything about this, we'll have to change not only reload.svg but also reload-to-stop.svg and stop-to-reload.svg. Not sure if UX uses tools to make that easy.

	Markus Stange [:mstange] Reporter
	Comment 5 • 7 years ago

Slightly, yes. It's less noticeable now, especially because the toolbar button no longer has a border on hover.

	Stephen Horlander [:shorlander]
	Comment 6 • 7 years ago

The new icon isn't as visually off-center.

Checking with Amy and Eric on how hard it is to move it 1px to the left :)

	Dão Gottwald [:dao]
	Comment 7 • 7 years ago

(In reply to Stephen Horlander [:shorlander] from comment #6)
> The new icon isn't as visually off-center.
> 
> Checking with Amy and Eric on how hard it is to move it 1px to the left :)

I think 1px is already too and makes it look unbalanced again. Maybe the arrow should become shorter.

	Eric Pang [:epang] UX
	Comment 8 • 7 years ago

(In reply to Dão Gottwald [::dao] from comment #7)
> (In reply to Stephen Horlander [:shorlander] from comment #6)
> > The new icon isn't as visually off-center.
> > 
> > Checking with Amy and Eric on how hard it is to move it 1px to the left :)
> 
> I think 1px is already too and makes it look unbalanced again. Maybe the
> arrow should become shorter.

Stephen, is there an update on what we want to do here based on Dão's comment?

Jared, is moving the icon 1px to the left something we can do in code or do I need to update the svg-sprite?

	Jared Wein [:jaws] (please needinfo? me)
	Comment 9 • 7 years ago

Eric, do you think 1px might be too much (as Dao says in comment 7)?

If we do this we would want to make the change in the SVG-sprite as well as the static icon. Also, would the stop button might need to shift too since they should be in the same position?

	Dão Gottwald [:dao]
	Comment 10 • 7 years ago

I'm moving this to photon-animation since photon-visual folks aren't equipped to to deal with the SVG sprite.

	Eric Pang [:epang] UX
	Comment 11 • 7 years ago

Looking at this in more detail I don't think it's worth the effort. Moving the icon by a pixel will cause the same problem as Dao mentioned in comment 7.  With the updated icon, visually it looks pretty centered anyway.

	Adolfo Jayme
	Comment 12 • 7 years ago

To me, this is a textbook example of bikeshedding.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 13 • 7 years ago

Closing per comment #11.