Closed Bug 1365002 Opened 7 years ago Closed 7 years ago

The back button's :active:not(:hover) state looks unintentional

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: mstange, Assigned: johannh)

References

Details

(Keywords: regression, Whiteboard: [photon-visual][p2])

Attachments

(1 file)

Bug 1365002 - Don't remove the back button background on state change.
(deleted), text/x-review-board-request
dao
: review+
Details
If you hold down the back button and move the mouse away from it, it ends up in a state that doesn't look like it was intentionally designed. Is there an :active selector somewhere that should be an :active:hover selector instead?
Assignee: nobody → jhofmann
Blocks: 1352364
Status: NEW → ASSIGNED
Flags: qe-verify+
Keywords: regression
Priority: -- → P1
Whiteboard: [photon-visual][p2]
Iteration: --- → 55.6 - May 29
QA Contact: brindusa.tot
Comment on attachment 8868110 [details] Bug 1365002 - Don't remove the back button background on state change. https://reviewboard.mozilla.org/r/139722/#review143428 ::: browser/themes/shared/toolbarbuttons.inc.css:371 (Diff revision 1) > padding: 7px !important; > } > > %ifdef MOZ_PHOTON_THEME > -#back-button:not(:hover):not(:active):not([open=true]) > .toolbarbutton-icon, > -#back-button[disabled=true] > .toolbarbutton-icon { > +#back-button > .toolbarbutton-icon { > + background: var(--backbutton-background); Please merge this into the previous #back-button > .toolbarbutton-icon rule.
Updated.
Comment on attachment 8868110 [details] Bug 1365002 - Don't remove the back button background on state change. https://reviewboard.mozilla.org/r/139722/#review143436 ::: browser/themes/shared/toolbarbuttons.inc.css:372 (Diff revision 2) > > #back-button > menupopup { > margin-top: -1px !important; > } > > #back-button > .toolbarbutton-icon { I meant this rule, though.
Attachment #8868110 - Flags: review?(dao+bmo) → review-
Comment on attachment 8868110 [details] Bug 1365002 - Don't remove the back button background on state change. https://reviewboard.mozilla.org/r/139722/#review143444 ::: browser/themes/shared/toolbarbuttons.inc.css:376 (Diff revision 3) > } > > #back-button > .toolbarbutton-icon { > %ifdef MOZ_PHOTON_THEME > border-color: var(--backbutton-border-color) !important; > + background: var(--backbutton-background); Please move background up to keep border-color and border-radius together.
Attachment #8868110 - Flags: review?(dao+bmo) → review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf6b08540d0c Don't remove the back button background on state change. r=dao
https://hg.mozilla.org/mozilla-central/rev/bf6b08540d0c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(In reply to Johann Hofmann [:johannh] from comment #1) > Created attachment 8868110 [details] > Bug 1365002 - Don't remove the back button background on state change. > > This CSS rule made certain actions on MacOS look strange, e.g. > active without hover, and it doesn't appear to be needed on the > other platforms since the background is always overriden when needed. Have you checked what made Mac behave differently? Is there some obsolete rule in browser.css that we should remove?
Flags: needinfo?(jhofmann)
(In reply to Dão Gottwald [::dao] from comment #11) > (In reply to Johann Hofmann [:johannh] from comment #1) > > Created attachment 8868110 [details] > > Bug 1365002 - Don't remove the back button background on state change. > > > > This CSS rule made certain actions on MacOS look strange, e.g. > > active without hover, and it doesn't appear to be needed on the > > other platforms since the background is always overriden when needed. > > Have you checked what made Mac behave differently? Is there some obsolete > rule in browser.css that we should remove? I don't think so, IIRC it's simply that the translucent back button didn't actually look different on the other platforms because of their toolbar background.
Flags: needinfo?(jhofmann)
I verified this issue on Mac OS X 10.12 with Nightly 57.0a1(2017-08-04) and I can confirm the fix.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: