Bug 1363844 (https://hg.mozilla.org/mozilla-central/rev/7b2c34b67962) added a new constant eDllBlocklistInitFlagIsChildProcess. This constant is used in mozglue/build/WindowsDllBlocklist.cpp but it is only defined in mozglue/build/WindowsDllBlocklist.h when #if defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64)) MinGW doesn't do that.

I'm wondering if we can just turn on the DLL Blocklist for Mingw.

boklm: I don't have a working MinGW or Tor build environment right now. Do you think you could test this patch and see if it works in Tor Browser? If so I'll try and land it.

(In reply to Tom Ritter [:tjr] from comment #3) > boklm: I don't have a working MinGW or Tor build environment right now. Do > you think you could test this patch and see if it works in Tor Browser? If > so I'll try and land it. I have been able to build Tor Browser using this patch (rebased on esr52). Do you want me to upload the build somewhere, or just being able to build is enough?

I uploaded the build there: https://people.torproject.org/~boklm/bug_1365047/torbrowser-install-7.0a4_en-US.exe.asc https://people.torproject.org/~boklm/bug_1365047/torbrowser-install-7.0a4_en-US.exe

Alright browser starts up and is usable for me, so I think this is good to go.

Comment on attachment 8867883 [details] Bug 1365047 Turn on the Windows DLL Blocklist in MinGW https://reviewboard.mozilla.org/r/139418/#review151530

Comment on attachment 8867883 [details] Bug 1365047 Turn on the Windows DLL Blocklist in MinGW I'll take this.

Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a6a5662822d Turn on the Windows DLL Blocklist in MinGW r=aklotz