Closed
Bug 1365053
Opened 8 years ago
Closed 7 years ago
Color picker no longer works after using the eyedropper
Categories
(DevTools :: Inspector, defect, P1)
DevTools
Inspector
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jdescottes, Assigned: zer0)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
STRs:
- go to any page
- open the inspector
- find a property with color swatch
- click on the color swatch
- click on the eyedropper
- pick any color on the page
- try to update the color using the color picker gradient
ER: Value should update as we move the cursor on the gradient
AR: Value only updates once
This behavior remains every time you re-open the color picker.
Updated•8 years ago
|
Priority: -- → P1
Updated•8 years ago
|
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8876613 [details]
Bug 1365053 - called `_onEyeDropperDone` once the color is selected;
https://reviewboard.mozilla.org/r/147940/#review152426
The fix looks good.
I wanted to check if a test would be easy to add, but for some reason, mochitests don't seem to work for me locally.
Did you try to add a small test based on devtools/client/inspector/rules/test/browser_rules_eyedropper.js ?
Could be nice to have non regression here :)
Attachment #8876613 -
Flags: review?(jdescottes) → review+
Comment 4•7 years ago
|
||
Added 2 ok() checks for eyedropperOpen and activeSwatch in browser_rules_eyedropper.js. Will also land this.
Attachment #8876613 -
Attachment is obsolete: true
Flags: needinfo?(zer0)
Attachment #8899215 -
Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71f4f2c0ec56
called `_onEyeDropperDone` once the color is selected; r=jdescottes
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 8•7 years ago
|
||
I have reproduced this bug according to (2017-09-12)
Fixing bug is verified on Latest Nightly & Latest Beta--
Build ID :20170923220337
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0
Latest Beta--
Build ID :20170918210324
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0
Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20170920]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•