Closed Bug 1365100 Opened 7 years ago Closed 7 years ago

stylo: background-image inheritance doesn't handle multiple images

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: manishearth, Assigned: mbrubeck)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1365100 - stylo: Fix inheritance of multiple background images.
(deleted), text/x-review-board-request
manishearth
: review+
Details
gecko patch for checkin
(deleted), patch
mbrubeck
: review+
Details | Diff | Splinter Review
https://github.com/servo/servo/blob/a51da06dd9c680a7e3f49247181d49a48a787f47/components/style/properties/gecko.mako.rs#L2854 Basically, `background-image: inherit` will only inherit the first image from the parent. This makes us fail layout/reftests/backgrounds/layers-layer-count-inheritance-2.xhtml (I'm surprised there aren't more tests that break because of this)
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Comment on attachment 8868220 [details] Bug 1365100 - stylo: Fix inheritance of multiple background images. https://reviewboard.mozilla.org/r/139796/#review143140
Attachment #8868220 - Flags: review?(manishearth) → review+
Attached patch gecko patch for checkin (deleted) — — Splinter Review
In case I'm not around when autoland reopens. https://github.com/servo/servo/pull/16896
Attachment #8868333 - Flags: review+
Pushed by mbrubeck@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e0d4ca8c7dd stylo: Update test expectations. r=Manishearth
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Priority: -- → P1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: