Move shortcut creation code in GeckoApp to GeckoApplication, and make the methods static so that we can call them without a GeckoInterface instance. This lets us remove GeckoInterface.createShortcut.

Comment on attachment 8868170 [details] [diff] [review] Move shortcut creation to static methods in GeckoApplication (v1) Review of attachment 8868170 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with a couple of nits. ::: mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java @@ +445,5 @@ > + } > + }); > + } > + > + /* protected */ static void createShortcutWithIcon(final String aTitle, final String aURI, Did you mean /* package */ here? ::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ActivityUtils.java @@ +61,5 @@ > > /** > * Finish this activity and launch the default home screen activity. > */ > + public static void goToHomeScreen(Context activity) { Rename activity to context.

Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5485d306e1 Move shortcut creation to static methods in GeckoApplication; r=droeh