Open
Bug 1365305
Opened 8 years ago
Updated 2 years ago
0.86ms uninterruptible reflow at _positionPinnedTabs@chrome://browser/content/tabbrowser.xml:6147:33
Categories
(Firefox :: Tabbed Browser, defect, P5)
Firefox
Tabbed Browser
Tracking
()
NEW
Performance Impact | low |
People
(Reporter: mconley, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [ohnoreflow][fxperf:p3])
Attachments
(1 file)
Here's the stack:
_positionPinnedTabs@chrome://browser/content/tabbrowser.xml:6147:33
onxbloverflow@chrome://browser/content/tabbrowser.xml:5696:9
That's this stuff: http://searchfox.org/mozilla-central/rev/ae24a3c83d22e0e35aecfd9049c2b463ca7e045b/browser/base/content/tabbrowser.xml#6154-6158
Reporter | ||
Updated•8 years ago
|
Component: Untriaged → Tabbed Browser
Updated•8 years ago
|
Flags: qe-verify?
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][photon-performance] [triage]
Updated•8 years ago
|
Priority: -- → P2
Whiteboard: [ohnoreflow][qf:p1][photon-performance] [triage] → [ohnoreflow][qf:p1][photon-performance]
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: adrian.florinescu
Updated•7 years ago
|
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Updated•7 years ago
|
Assignee: nobody → jiangperry
Status: NEW → ASSIGNED
Updated•7 years ago
|
Priority: P3 → P1
Comment 1•7 years ago
|
||
I wasn't able to detect this reflow with ohnoreflow on Nightly 57.0a1 (2017-08-02) when the code around this.childNodes[0].getBoundingClientRect().width gets called.
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 2•7 years ago
|
||
Hey Perry,
I'm going to re-open this. It's quite possible that:
1) Oh no! Reflow! is running with too high a threshold to detect it
2) The STR are very precise - likely also occurring once per browser window, because it looks like we're caching some results here: http://searchfox.org/mozilla-central/rev/ae24a3c83d22e0e35aecfd9049c2b463ca7e045b/browser/base/content/tabbrowser.xml#6151-6159
Still, we're using getBoundingClientRect(), which guarantees a layout flush if we ever hit that codepath with a dirty DOM. So I think this bug is still legitimate.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment 3•7 years ago
|
||
Attachment #8895977 -
Flags: review?(mconley)
Comment 4•7 years ago
|
||
Comment on attachment 8895977 [details] [diff] [review]
Bug 1365305 - wrap _positionPinnedTabs's getBoundingClientRect() in requestAnimationFrame
This makes the pinned tab area flicker when the tab strip overflows.
Attachment #8895977 -
Flags: review?(mconley) → review-
Comment 5•7 years ago
|
||
I believe that we should downgrade this bug from p1 to a p2 or even a p3. There's a sync reflow here to get the pinned tab dimensions, but that only happens only once per session, and then that information is cached and the reflow won't happen again. Also, pinned tabs are not a widely known feature. And it's not clear there's a non-flickering way to avoid this reflow.
I'm directly marking as a p2. If anyone disagrees feel free to change it back.
Assignee: jiangperry → nobody
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
Updated•7 years ago
|
Status: REOPENED → NEW
Priority: P1 → P3
Updated•7 years ago
|
Priority: P3 → P4
Reporter | ||
Comment 6•7 years ago
|
||
Setting this to qf:p3 as per comment 5 for now.
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][qf:p3][reserve-photon-performance]
Updated•7 years ago
|
Whiteboard: [ohnoreflow][qf:p3][reserve-photon-performance] → [ohnoreflow][qf:p3][reserve-photon-performance] [fxperf]
Updated•7 years ago
|
Whiteboard: [ohnoreflow][qf:p3][reserve-photon-performance] [fxperf] → [ohnoreflow][qf:p3][reserve-photon-performance] [fxperf:p3]
Reporter | ||
Updated•7 years ago
|
Whiteboard: [ohnoreflow][qf:p3][reserve-photon-performance] [fxperf:p3] → [ohnoreflow][qf:p3][fxperf:p3]
Updated•6 years ago
|
Priority: P4 → P5
Updated•3 years ago
|
Performance Impact: --- → P3
Whiteboard: [ohnoreflow][qf:p3][fxperf:p3] → [ohnoreflow][fxperf:p3]
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•