Closed
Bug 1365306
Opened 8 years ago
Closed 8 years ago
Remove parts of bug 1312754 and bug 1348061
Categories
(Core :: Networking: HTTP, enhancement, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
(deleted),
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
Based on bug 1362071 comment 1.
Only left should be:
- nsHttpHandler::ThrottleTransaction down to nsHttpConnectionMgr::OnMsgThrottleTransaction
- preferences in all.js
- nsHttpChannel::OnClassOfServiceUpdated() calling only gHttpHandler->ThrottleTransaction
- nsHttpTransaction::mThrottleResponse
Everything else introduced in these two bugs can go.
|
||
Updated•8 years ago
|
Whiteboard: [necko-backlog]
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Whiteboard: [necko-backlog] → [necko-active]
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8869224 [details] [diff] [review]
v1 (remove Throttling service et al)
Nick, I'm sorry to remove your child, but it turns out we need a more sophisticated mechanism (being born in bug 1365307).
This patch only leaves few bits which that bug may use (including all.js preferences).
Thanks.
Attachment #8869224 -
Attachment description: v1 [builds] → v1 (remove Throttling service et al)
Attachment #8869224 -
Flags: review?(hurley)
Comment on attachment 8869224 [details] [diff] [review]
v1 (remove Throttling service et al)
Review of attachment 8869224 [details] [diff] [review]:
-----------------------------------------------------------------
Which child?! I have more than... oooooooooh, you mean code I wrote! :)
The only good code is removed code!
Attachment #8869224 -
Flags: review?(hurley) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) from comment #3)
> Comment on attachment 8869224 [details] [diff] [review]
> v1 (remove Throttling service et al)
>
> Review of attachment 8869224 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Which child?! I have more than... oooooooooh, you mean code I wrote! :)
>
> The only good code is removed code!
:D thanks!
|
|
Assignee | |
Comment 5•8 years ago
|
||
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d329c85dfb
Remove net::ThrottlingService, don't suspend/resume download channels on page load. r=hurley
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•