Closed Bug 1365417 Opened 7 years ago Closed 7 years ago

mozJSComponentLoader::FindTargetObject() is infallible

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 1365417 - mozJSComponentLoader::FindTargetObject() is infallible.
(deleted), text/x-review-board-request
kmag
: review+
Details
This method return an nsresult, but it doesn't need to.
I asked bholley if it was okay for kmag to review some loader cleanups, and he said it was.
Comment on attachment 8869112 [details] Bug 1365417 - mozJSComponentLoader::FindTargetObject() is infallible. https://reviewboard.mozilla.org/r/140744/#review144222
Attachment #8869112 - Flags: review?(kmaglione+bmo) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94f5cca9efba mozJSComponentLoader::FindTargetObject() is infallible. r=kmag
https://hg.mozilla.org/mozilla-central/rev/94f5cca9efba
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: