Closed
Bug 1365647
Opened 8 years ago
Closed 8 years ago
Ensure that the height of panel views does not shrink smaller that of the main view
Categories
(Firefox :: Toolbars and Customization, enhancement, P1)
Firefox
Toolbars and Customization
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
(Whiteboard: [photon-structure])
Attachments
(1 file)
To control the height of each panel sub view, we can simply set the min-height CSS property for each panel individually to match the height of the main view.
Once the panel is opened for the first time, the main view is shown. From that point forward, it will never change its minimum allowed height for the subviews.
Flags: qe-verify+
Comment 1•8 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #0)
> To control the height of each panel sub view, we can simply set the
> min-height CSS property for each panel individually to match the height of
> the main view.
>
> Once the panel is opened for the first time, the main view is shown. From
> that point forward, it will never change its minimum allowed height for the
> subviews.
What happens with banner notifications at the top that get shown later?
Feels like we might need to clear the min-height onpopuphidden and re-set it onpopupshown.
Assignee | ||
Comment 2•8 years ago
|
||
Good idea!
Updated•8 years ago
|
QA Contact: gwimberly
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8870060 [details]
Bug 1365647 - Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu.
https://reviewboard.mozilla.org/r/141560/#review145278
Haven't tested this, but code-wise it looks great. Thanks!
::: commit-message-9723d:1
(Diff revision 1)
> +Bug 1365647 - Make sure that the panel height never shrinks below the width of the main view in panelviews, like the main menu. r?Gijs
s/width/height/ :-)
::: browser/components/customizableui/PanelMultiView.jsm:566
(Diff revision 1)
> let listener;
> - let seen = 0;
> this._viewContainer.addEventListener("transitionend", listener = ev => {
> - if (ev.target == this._viewContainer && ev.propertyName == "height") {
> + // It's quite common that `height` on the view container doesn't need
> + // to transition, so we make sure to do all the work on the transform
> + // transition, because that is ensure to happen.
Spelling nit: 'sure' or 'guaranteed'.
Attachment #8870060 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69c77ef0e94d
Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu. r=Gijs
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Hi Gijs,
Any suggested/recommended STR to be able to verify this? Thanks!
Flags: needinfo?(gijskruitbosch+bugs)
Comment 9•8 years ago
|
||
(In reply to Grover Wimberly IV [:Grover-QA] from comment #8)
> Hi Gijs,
>
> Any suggested/recommended STR to be able to verify this? Thanks!
Hi Grover,
With the photon pref enabled:
1) open the hamburger / main panel/menu
2) open the different items that open slide-in subviews ("More", "More > Character encoding", "Web Developer", ...)
3) check that the height of the panel can increase where necessary, but doesn't decrease (ie the panel doesn't get smaller after it's initially been opened)
Flags: needinfo?(gijskruitbosch+bugs)
Comment 10•8 years ago
|
||
Verified on Windows, Mac, and Ubuntu.
You need to log in
before you can comment on or make changes to this bug.
Description
•