Closed Bug 1365911 Opened 8 years ago Closed 8 years ago

Add-on icon is not hidden when pageproxystate=false (editing the URL bar)

Categories

(Firefox :: Site Identity, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: johannh, Assigned: johannh)

References

Details

Attachments

(1 file)

We hide all icons and fade the (i) when the user has changed the page url.
Comment on attachment 8869016 [details] Bug 1365911 - Hide extension identity icon on pageproxystate=false. https://reviewboard.mozilla.org/r/140680/#review144142 Thanks for adding this - looks good to me. Adding mixedpuppy for the stamp of approval. ::: browser/themes/shared/identity-block/identity-block.inc.css:154 (Diff revision 1) > opacity: 0; > /* Only animate the shield in, when it disappears hide it immediately. */ > transition: none; > } > > +#urlbar[pageproxystate="invalid"] > #identity-box > #extension-icon, It's not necessary, but I think it would be nice if all of the pageproxystate rules were put in one place: http://searchfox.org/mozilla-central/search?q=pageproxystate&case=false&regexp=false&path=.css
Attachment #8869016 - Flags: review?(mwein) → review+
Attachment #8869016 - Flags: review?(mixedpuppy)
(In reply to Matthew Wein [:mattw] from comment #2) > It's not necessary, but I think it would be nice if all of the > pageproxystate rules were put in one place: > > http://searchfox.org/mozilla-central/ > search?q=pageproxystate&case=false&regexp=false&path=.css I had the same thought but I'd like to solve that in a different bug. :)
(In reply to Johann Hofmann [:johannh] from comment #3) > (In reply to Matthew Wein [:mattw] from comment #2) > > It's not necessary, but I think it would be nice if all of the > > pageproxystate rules were put in one place: > > > > http://searchfox.org/mozilla-central/ > > search?q=pageproxystate&case=false&regexp=false&path=.css > > I had the same thought but I'd like to solve that in a different bug. :) Okay, sounds good :)
Can someone post a followup bug?
Comment on attachment 8869016 [details] Bug 1365911 - Hide extension identity icon on pageproxystate=false. https://reviewboard.mozilla.org/r/140680/#review144188
Attachment #8869016 - Flags: review?(mixedpuppy) → review+
Blocks: 1366200
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d808a3a6463 Hide extension identity icon on pageproxystate=false. r=mattw,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: