Open Bug 1366246 Opened 7 years ago Updated 2 years ago

Ensure that browser.contentTitle reflects the stored title throughout the restoration process

Categories

(Firefox :: Session Restore, enhancement)

enhancement

Tracking

()

People

(Reporter: dao, Unassigned)

References

(Blocks 2 open bugs)

Details

(In reply to Dão Gottwald [::dao] from bug 1365780 comment #5)
> (In reply to Mike de Boer [:mikedeboer] from bug 1365780 comment #4)
> > > +            aTab._labelIsContentTitle = aOptions && aOptions.isContentTitle;
> > 
> > I'm kind of starting to dislike the mixed bag and sheer amount of
> > properties, attributes and other state-tracking-variables we mix throughout
> > the binding and at this rate it's only going to be more.
> 
> We could avoid adding this one if sessionstore ensured that
> browser.contentTitle consistently returned the stored title throughout the
> restoration process. Do you know if it currently does that? I believe
> between the lazy, pending, restoring history and loading states,
> contentTitle may be intermittently empty.

(In reply to Mike de Boer [:mikedeboer] from bug 1365780 comment #7)
> There have been changes there in that regard recently, but it's too early to
> say 'yes' with 100% certainty. Not with enough certainty, at least, to
> simplify the patch here.

Once we're confident about browser.contentTitle's reliability, we can use that in getWindowTitleForBrowser and get rid of tab._labelIsContentTitle.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.