Closed
Bug 1366445
Opened 8 years ago
Closed 8 years ago
Permaorange in browser_form_post_from_file_to_http.js and browser_new_web_tab_in_file_process_pref.js when Gecko 55 merges to mozilla-beta on 2017-06-12
Categories
(Core :: DOM: Content Processes, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | blocking | fixed |
People
(Reporter: philor, Assigned: bobowen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Don't forget to set browser.tabs.remote.separateFileUriProcess in your tests, so you won't get https://treeherder.mozilla.org/logviewer.html#?job_id=100612475&repo=try and https://treeherder.mozilla.org/logviewer.html#?job_id=100612570&repo=try when we merge to beta in three weeks and that pref flips to false.
[Tracking Requested - why for this release]: potential merge bustage, potential closed tree, potential delayed b1.
Reporter | ||
Comment 1•8 years ago
|
||
Though I'm just guessing it's only because of that pref, I haven't actually tested that it is.
Flags: needinfo?(bobowencode)
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #1)
> Though I'm just guessing it's only because of that pref, I haven't actually
> tested that it is.
Thanks philor, pretty much.
browser_form_post_from_file_to_http.js is because I forgot to add setting the pref at all.
browser_new_web_tab_in_file_process_pref.js is because I'm an idiot and set the prefs after I've opened the first file:// page.
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
Flags: needinfo?(bobowencode)
Assignee | ||
Comment 3•8 years ago
|
||
This fixes:
browser\base\content\test\tabs\browser_new_web_tab_in_file_process_pref.js
dom\html\test\browser_form_post_from_file_to_http.js
Attachment #8869843 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•8 years ago
|
||
Comment on attachment 8869843 [details] [diff] [review]
Add and correct pref settings for some file content process tests
Review of attachment 8869843 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #8869843 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 5•8 years ago
|
||
marking as blocking 55.
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcadba7f3b6d
Add and correct pref settings for some file content process tests. r=Gijs
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•