Richard Marti (:Paenglab) Assignee
	Description • 7 years ago

From bug 1356244 comment 0:
Once DevTools are going to be shipped as an add-on, various code in Firefox is still going to depend on devtools, like WebExtension for example.
We still need some code in mozilla-central/Firefox to ease interacting with Devtools. This code should expose whatever API is required by Firefox codebase and react to the installation of the DevTools Add-on. It may also automatically install the add-on under some circonstance.

The main goal of this bug is to introduce this module and keep all tests green in the three following setup:
* with this module (and the related refactoring) on mozilla-central tip,
* same, but with DevTools being stripped from mozilla-central,
* on the incoming DevTools repo, with all the DevTools tests (xpcshell, mochitests), we may move some tests from m-c to devtools, like webextension tests related to devtools APIs.

Keeping mozilla-central tests green while devtools is being removed depends on some other bugs like bug 1356231, bug 1356231 and some other to come. In some cases we have to refactor m-c codebase to just stop depending on devtools.

This bug isn't related to the shim layer that will help web developers automatically install the add-on. Instead, it is focused on the low level shim that keep everything working when we do not have devtools and then install it.

	Richard Marti (:Paenglab) Assignee
	Comment 1 • 7 years ago

Port to c-c

	Jorg K (CEST = GMT+2)
	Comment 2 • 7 years ago

Note that bug 1356244 landed:
https://hg.mozilla.org/mozilla-central/rev/e18063b2ed57#l1.35

So I put a print into
comm-central/mozilla/devtools/client/framework/ devtools.js - function DevTools() - to see whether it's executed. It is executed, so we really need to package that stuff.

Richard, you said in a PM that DevTools still work without packaging, but don't you see an error in the console? Something like "DevToolsShim not defined"?

	Jorg K (CEST = GMT+2)
	Comment 3 • 7 years ago

Comment on attachment 8869755 [details] [diff] [review]
Bug1366507.patch

I convinced myself that we need this.

	Jorg K (CEST = GMT+2)
	Comment 4 • 7 years ago

https://hg.mozilla.org/comm-central/rev/9285e79dfd098b4d5e6de6c12550e72c98387ce4

I needed to fix the patch before landing it, "browser/" had to be removed.

I landed it since without it we have Xpcshell test failures.

	Richard Marti (:Paenglab) Assignee
	Comment 5 • 7 years ago

Good catch. Thank you.